Fix error sorting the Uncaptured table using Capture by column (#5185)

This change fixes an error in the Uncaptured transactions table, when the table is sorted clicking on the Capture by column.
The error is caused by a 500 response from the endpoint, because 'capture_by' is not a valid sorting field in the API, since it is a value calculated in the front end, derived from the 'created' field.

To solve the issue, I am rewriting the orderby field in the resolver to 'created', in case the 'capture_by' field is specified. This has the same effect, and does not cause an error in the API endpoint.

Author: mgascam

changelog/fix-5184-sort-by-capture-by-column-of-uncaptured-transactions-table-causes-an-error

@@ -0,0 +1,4 @@
+Significance: patch
+Type: fix
+
+Fix an error in the Uncaptured transactions table when it is sorted using the Capture by column.

client/data/authorizations/resolvers.ts

@@ -27,13 +27,18 @@ import { NAMESPACE } from '../constants';
 import { ApiError } from 'wcpay/types/errors';
 
 export function* getAuthorizations( query: Query ): Generator< unknown > {
-	const {
+	let {
 		paged = 1,
 		per_page: perPage = 25,
 		orderby = 'created',
 		order = 'desc',
 	} = query;
 
+	if ( orderby === 'capture_by' ) {
+		// The API does not expect 'capture_by' to be a valid sorting field, since it is a derived field, calculated from the 'created' field.
+		orderby = 'created';
+	}
+
 	const path = addQueryArgs( `${ NAMESPACE }/authorizations`, {
 		page: paged,
 		pagesize: perPage,

client/transactions/uncaptured/index.tsx

@@ -55,10 +55,8 @@ const getColumns = (): Column[] =>
 			screenReaderLabel: __( 'Capture by', 'woocommerce-payments' ),
 			required: true,
 			isLeftAligned: true,
-			defaultOrder: 'desc',
 			cellClassName: 'date-time',
 			isSortable: true,
-			defaultSort: true,
 		},
 		{
 			key: 'order',