Replace the deprecated wcs_renewal_order_meta_query with a new hook (#5052)

* Replace the deprecated wcs_renewal_order_meta_query with a new hook

* Add changelog

* Add the missing s

Author: james-allan

changelog/update-deprecated_renewal_order_hook

@@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Replace the use of the deprecated wcs_renewal_order_meta_query hook with wc_subscription_renewal_order_data

includes/compat/subscriptions/trait-wc-payment-gateway-wcpay-subscriptions.php

@@ -140,7 +140,11 @@ public function maybe_init_subscriptions() {
 		add_filter( 'woocommerce_my_subscriptions_payment_method', [ $this, 'maybe_render_subscription_payment_method' ], 10, 2 );
 
 		// Used to filter out unwanted metadata on new renewal orders.
-		add_filter( 'wcs_renewal_order_meta_query', [ $this, 'update_renewal_meta_data' ], 10, 3 );
+		if ( ! class_exists( 'WC_Subscriptions_Data_Copier' ) ) {
+			add_filter( 'wcs_renewal_order_meta_query', [ $this, 'update_renewal_meta_data' ], 10, 3 );
+		} else {
+			add_filter( 'wc_subscriptions_renewal_order_data', [ $this, 'remove_data_renewal_order' ], 10, 3 );
+		}
 
 		// Allow store managers to manually set Stripe as the payment method on a subscription.
 		add_filter( 'woocommerce_subscription_payment_meta', [ $this, 'add_subscription_payment_meta' ], 10, 2 );
@@ -733,6 +737,18 @@ public function update_renewal_meta_data( $order_meta_query, $to_order, $from_or
 		return $order_meta_query;
 	}
 
+	/**
+	 * Removes the data that we don't need to copy to renewal orders.
+	 *
+	 * @param array $order_data Renewal order data.
+	 *
+	 * @return array The renewal order data with the data we don't want copied removed
+	 */
+	public function remove_data_renewal_order( $order_data ) {
+		unset( $order_data['_new_order_tracking_complete'] );
+		return $order_data;
+	}
+
 	/**
 	 * Adds the failed SCA auth email to WooCommerce.
 	 *