Restore original position of set_fraud_meta_box_type_for_order after update_order_status

The previous commit incorrectly moved set_fraud_meta_box_type_for_order
before update_order_status. Only set_pos_payment_context_for_order needs
to be called before the status change (so POS context is available during
status transition hooks). The fraud meta box type should remain in its
original position after the status change.

Author: staskus

includes/class-wc-payments-order-service.php

@@ -470,8 +470,8 @@ public function mark_terminal_payment_completed( $order, $intent_id, $intent_sta
 		$order_status = apply_filters( 'wcpay_terminal_payment_completed_order_status', Order_Status::COMPLETED );
 
 		$this->set_pos_payment_context_for_order( $order, 'card_reader' );
-		$this->set_fraud_meta_box_type_for_order( $order, Fraud_Meta_Box_Type::TERMINAL_PAYMENT );
 		$this->update_order_status( $order, $order_status, $intent_id );
+		$this->set_fraud_meta_box_type_for_order( $order, Fraud_Meta_Box_Type::TERMINAL_PAYMENT );
 		$this->complete_order_processing( $order, $intent_status );
 	}