Skip to content

Commit 829ed87

Browse files
authored
Prevent the double-zip issue when downloading from zip file workflow (#5135)
1 parent 47e7692 commit 829ed87

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

.github/workflows/build-zip-file.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,17 @@ jobs:
1818
- name: "Build the plugin"
1919
id: build_plugin
2020
uses: ./.github/actions/build
21+
22+
- name: "Unzip the file (prevents double zip issue)"
23+
run: |
24+
echo ":information_source: Unzipping to a folder to prevent double-zip issue ([known limitation](https://github.com/actions/upload-artifact#zipped-artifact-downloads)). Increase in artifact size is expected since we're uploading the folder." >> $GITHUB_STEP_SUMMARY
25+
unzip ${{ steps.build_plugin.outputs.release-filename }} -d zipfile
2126
2227
- name: "Upload the zip file as an artifact"
2328
uses: actions/upload-artifact@v3
2429
env:
2530
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2631
with:
2732
name: "woocommerce-payments"
28-
path: ${{ steps.build_plugin.outputs.release-filename }}
33+
path: zipfile
2934
retention-days: 7
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
Significance: patch
2+
Type: fix
3+
Comment: Just a minor fix in a github workflow
4+
5+

0 commit comments

Comments
 (0)