Skip to content

Commit a76809a

Browse files
frossoCopilotrtio
authored
update: support phone label text (#10979)
Co-authored-by: Copilot <[email protected]> Co-authored-by: Rafael Meneses <[email protected]>
1 parent 266b53c commit a76809a

File tree

3 files changed

+46
-75
lines changed

3 files changed

+46
-75
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Significance: patch
2+
Type: update
3+
4+
update: label text on the support phone number in test mode

client/settings/support-phone-input/__tests__/support-phone-input.test.js

Lines changed: 24 additions & 64 deletions
Original file line numberDiff line numberDiff line change
@@ -110,58 +110,33 @@ describe( 'SupportPhoneInput', () => {
110110
container.querySelector( '.components-notice.is-error' )
111111
).toBeNull();
112112

113-
fireEvent.change(
114-
screen.getByLabelText(
115-
'Support phone number (+1 0000000000 can be used for test accounts)'
116-
),
117-
{
118-
target: { value: '+6580000000' },
119-
}
120-
);
113+
fireEvent.change( screen.getByLabelText( 'Support phone number' ), {
114+
target: { value: '+6580000000' },
115+
} );
121116
expect(
122117
container.querySelector( '.components-notice.is-error' )
123118
).toBeNull();
124-
fireEvent.change(
125-
screen.getByLabelText(
126-
'Support phone number (+1 0000000000 can be used for test accounts)'
127-
),
128-
{
129-
target: { value: '+6580500000' },
130-
}
131-
);
119+
fireEvent.change( screen.getByLabelText( 'Support phone number' ), {
120+
target: { value: '+6580500000' },
121+
} );
132122
expect(
133123
container.querySelector( '.components-notice.is-error' )
134124
).toBeNull();
135-
fireEvent.change(
136-
screen.getByLabelText(
137-
'Support phone number (+1 0000000000 can be used for test accounts)'
138-
),
139-
{
140-
target: { value: '+6580700000' },
141-
}
142-
);
125+
fireEvent.change( screen.getByLabelText( 'Support phone number' ), {
126+
target: { value: '+6580700000' },
127+
} );
143128
expect(
144129
container.querySelector( '.components-notice.is-error' )
145130
).toBeNull();
146-
fireEvent.change(
147-
screen.getByLabelText(
148-
'Support phone number (+1 0000000000 can be used for test accounts)'
149-
),
150-
{
151-
target: { value: '+6580800000' },
152-
}
153-
);
131+
fireEvent.change( screen.getByLabelText( 'Support phone number' ), {
132+
target: { value: '+6580800000' },
133+
} );
154134
expect(
155135
container.querySelector( '.components-notice.is-error' )
156136
).toBeNull();
157-
fireEvent.change(
158-
screen.getByLabelText(
159-
'Support phone number (+1 0000000000 can be used for test accounts)'
160-
),
161-
{
162-
target: { value: '+6580900000' },
163-
}
164-
);
137+
fireEvent.change( screen.getByLabelText( 'Support phone number' ), {
138+
target: { value: '+6580900000' },
139+
} );
165140
expect(
166141
container.querySelector( '.components-notice.is-error' )
167142
).toBeNull();
@@ -179,38 +154,23 @@ describe( 'SupportPhoneInput', () => {
179154
container.querySelector( '.components-notice.is-error' )
180155
).toBeNull();
181156

182-
fireEvent.change(
183-
screen.getByLabelText(
184-
'Support phone number (+1 0000000000 can be used for test accounts)'
185-
),
186-
{
187-
target: { value: '+85241234567' },
188-
}
189-
);
157+
fireEvent.change( screen.getByLabelText( 'Support phone number' ), {
158+
target: { value: '+85241234567' },
159+
} );
190160
expect(
191161
container.querySelector( '.components-notice.is-error' )
192162
).toBeNull();
193163

194-
fireEvent.change(
195-
screen.getByLabelText(
196-
'Support phone number (+1 0000000000 can be used for test accounts)'
197-
),
198-
{
199-
target: { value: '+85271234567' },
200-
}
201-
);
164+
fireEvent.change( screen.getByLabelText( 'Support phone number' ), {
165+
target: { value: '+85271234567' },
166+
} );
202167
expect(
203168
container.querySelector( '.components-notice.is-error' )
204169
).toBeNull();
205170

206-
fireEvent.change(
207-
screen.getByLabelText(
208-
'Support phone number (+1 0000000000 can be used for test accounts)'
209-
),
210-
{
211-
target: { value: '+85281234567' },
212-
}
213-
);
171+
fireEvent.change( screen.getByLabelText( 'Support phone number' ), {
172+
target: { value: '+85281234567' },
173+
} );
214174
expect(
215175
container.querySelector( '.components-notice.is-error' )
216176
).toBeNull();

client/settings/support-phone-input/index.js

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,7 @@ const SupportPhoneInput = ( { setInputVallid } ) => {
5454
}
5555
}, [ supportPhoneError, setInputVallid ] );
5656

57-
let labelText = __( 'Support phone number', 'woocommerce-payments' );
58-
if ( isTestModeOnboarding ) {
59-
labelText += __(
60-
' (+1 0000000000 can be used for test accounts)',
61-
'woocommerce-payments'
62-
);
63-
}
57+
const labelText = __( 'Support phone number', 'woocommerce-payments' );
6458
return (
6559
<>
6660
{ supportPhoneError && (
@@ -70,10 +64,23 @@ const SupportPhoneInput = ( { setInputVallid } ) => {
7064
) }
7165
<BaseControl
7266
className="settings__account-business-support-phone-input no-top-margin"
73-
help={ __(
74-
'This may be visible on receipts, invoices, and automated emails from your store.',
75-
'woocommerce-payments'
76-
) }
67+
help={
68+
<>
69+
{ __(
70+
'This may be visible on receipts, invoices, and automated emails from your store.',
71+
'woocommerce-payments'
72+
) }
73+
{ isTestModeOnboarding && (
74+
<>
75+
<br />
76+
{ __(
77+
'(+1 0000000000 can be used for test accounts)',
78+
'woocommerce-payments'
79+
) }
80+
</>
81+
) }
82+
</>
83+
}
7784
label={ labelText }
7885
id="account-business-support-phone-input"
7986
__nextHasNoMarginBottom

0 commit comments

Comments
 (0)