Skip to content

Commit cbfc040

Browse files
authored
Fix naming of REMOTE_PORT to more self-documented (#5322)
1 parent f933120 commit cbfc040

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
Significance: patch
2+
Type: dev
3+
Comment: naming changes to Dockerfile arg

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ services:
1010
context: .
1111
dockerfile: ./docker/wordpress_xdebug/Dockerfile
1212
args:
13-
- REMOTE_PORT=9000 # IDE/Editor's listener port
13+
- XDEBUG_REMOTE_PORT=9000 # IDE/Editor's listener port
1414
container_name: woocommerce_payments_wordpress
1515
image: woocommerce_payments_wordpress
1616
restart: always

docker/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ services:
5555
wordpress:
5656
build:
5757
args:
58-
- REMOTE_PORT=9003 # IDE/Editor's listener port
58+
- XDEBUG_REMOTE_PORT=9003 # IDE/Editor's listener port
5959
```
6060
I used port `9003` as an example.
6161
To apply the change, restart your containers using `npm run down && npm run up`

docker/wordpress_xdebug/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
FROM wordpress:php7.4
2-
ARG REMOTE_PORT
2+
ARG XDEBUG_REMOTE_PORT
33
RUN pecl install xdebug-2.9.8 \
44
&& echo 'xdebug.remote_enable=1' >> $PHP_INI_DIR/php.ini \
5-
&& echo "xdebug.remote_port=$REMOTE_PORT" >> $PHP_INI_DIR/php.ini \
5+
&& echo "xdebug.remote_port=$XDEBUG_REMOTE_PORT" >> $PHP_INI_DIR/php.ini \
66
&& echo 'xdebug.remote_host=host.docker.internal' >> $PHP_INI_DIR/php.ini \
77
&& echo 'xdebug.remote_autostart=0' >> $PHP_INI_DIR/php.ini \
88
&& docker-php-ext-enable xdebug

0 commit comments

Comments
 (0)