Updated the versions matrix to test our code in CI (#1322)

* Updated the versions matrix to test our code in CI

Closes #780

The new build mamtrix includes a variety of these versions:
WordPress:
- 4.4 (earliest supported by WooCommerce 2.6)
- 4.5
- 4.6
- 4.7
- 4.8
- `latest` (4.9 at the moment of writing this)
WooCommerce:
- 2.6.14 (earliest supported by WCS for now)
- 3.0.9
- 3.1.3
- 3.2.6
- 3.3.3 (latest)
PHP:
- 5.2 (earliest we support)
- 5.3
- 5.4
- 5.5
- 5.6
- 7.0
- 7.1
- 7.2 (latest)

I added a sensible matrix so we don't hog TravisCI resources for no reason. I made sure that these situations are covered:
- Earliest PHP version with latest WC and WP versions.
- Earliest PHP, WC and WP versions.
- Latest PHP versions with earliest WC and WP versions.
- Latest PHP, WC and WP versions.
- Earliest WC version with latest WP version.
- Earliest WP version with latest WC version.

If you ask me, that's already overkill, but the new matrix is slightly shorter than before (1 case less), so I think that's OK. Thoughts?

No testing instructions, just check that CI passes.

* Fixed typo

* Next try

* Move JS tests to a different container

* Fix tar command

* Roll back the `install_wc` change, since the "tests" directory is exclude from the Git zipball/tarball, cloning the repo is the only way to get them.

* Fixed test on WooCommerce 3.3.

The helper `WC_Helper_Product::create_simple_product()` added a default `weight` in the latest WC version, so that was breaking a test that assumed that the product wouldn't have a valid weight set up.

* See what PHPUnit versions are installed.

* Try installing a previous version of PHPUnit for PHP 7.2

* Manually install an even older version of PHPUnit for PHP 7.2.

Author: DanReyLop

.travis.yml

@@ -3,79 +3,45 @@
 # Tell Travis CI we're using PHP
 language: php
 
-# PHP version used in first build configuration.
-php:
-    - 5.6
-
-# WordPress version used in first build configuration.
-env:
-    - WP_VERSION=latest
-
-# Next we define our matrix of additional build configurations to test against.
-# The versions listed above will automatically create our first configuration,
-# so it doesn't need to be re-defined below.
-
-# Test WP trunk/master and two latest versions on minimum (5.2).
-# Test WP latest two versions (4.4, 4.4) on most popular (5.5, 5.6).
-# Test WP latest stable (4.4) on other supported PHP (5.3, 5.4).
-# Test WP trunk/master on edge platforms (7.0, hhvm, PHP nightly).
-
-# WP_VERSION specifies the tag to use. The way these tests are configured to run
-# requires at least WordPress 3.8. Specify "master" to test against SVN trunk.
-
+# Define our matrix of build configurations to test against.
 matrix:
   include:
-   - php: 5.2
-     env: WP_VERSION=latest WC_VERSION=2.6.14
-     sudo: true
-     dist: precise
    - php: 5.2
      env: WP_VERSION=4.4 WC_VERSION=2.6.14
      sudo: true
      dist: precise
-   - php: 5.3
-     env: WP_VERSION=latest WC_VERSION=2.6.14
+   - php: 5.2
+     env: WP_VERSION=latest WC_VERSION=3.3.3
      sudo: true
      dist: precise
    - php: 5.3
-     env: WP_VERSION=4.4 WC_VERSION=2.6.14
+     env: WP_VERSION=4.5 WC_VERSION=3.2.6
      sudo: true
      dist: precise
    - php: 5.4
-     env: WP_VERSION=latest WC_VERSION=2.6.14
-   - php: 5.4
-     env: WP_VERSION=4.4 WC_VERSION=2.6.14
+     env: WP_VERSION=4.6 WC_VERSION=3.1.2
    - php: 5.5
+     env: WP_VERSION=4.7 WC_VERSION=3.0.9
+   - php: 5.6
+     env: WP_VERSION=4.8 WC_VERSION=2.6.14
+   - php: 7.0
      env: WP_VERSION=latest WC_VERSION=2.6.14
-   - php: 5.5
-     env: WP_VERSION=4.4 WC_VERSION=2.6.14
-   - php: 5.5
+   - php: 7.1
      env: WP_VERSION=latest WC_VERSION=3.0.3
-     # 5.6 / master already included above as first build.
-   - php: 5.6
+   - php: 7.2
      env: WP_VERSION=4.4 WC_VERSION=2.6.14
-   - php: 5.6
-     env: WP_VERSION=4.4 WC_VERSION=3.0.3
-
-# Cache the NPM dependencies
-cache:
-  directories:
-    - node_modules
-    - "$HOME/.nvm"
-
-# Use an updated Node runtime
-# See: http://entulho.fiatjaf.alhur.es/guias/how-to-use-node-along-with-other-language-on-travis-ci/
-install:
-    - . $HOME/.nvm/nvm.sh
-    - nvm install 8.9.3
-    - nvm use 8.9.3
-    - npm install
+     # Older versions of WP are not compatible with PHPUnit 6+. Manually install PHPUnit 5.
+     script: curl -sSfL -o ~/.phpenv/versions/7.2/bin/phpunit https://phar.phpunit.de/phpunit-5.7.phar && phpunit
+   - php: 7.2
+     env: WP_VERSION=latest WC_VERSION=3.3.3
+     # Not even the latest WP version is compatible with PHPUnit 7. Manually install PHPUnit 6.
+     script: curl -sSfL -o ~/.phpenv/versions/7.2/bin/phpunit https://phar.phpunit.de/phpunit-6.4.phar && phpunit
+     # Run the JS tests in a separate container
+   - language: node_js
+     before_script: ""
 
 # Clones WordPress and configures our testing environment.
-before_script:
-    - bash tests/bin/install-wc-tests.sh wordpress_test root '' localhost $WP_VERSION $WC_VERSION
-
-script: phpunit && npm test
+before_script: bash tests/bin/install-wc-tests.sh wordpress_test root '' localhost $WP_VERSION $WC_VERSION
 
 sudo: false
 

tests/php/test_class-wc-connect-api-client.php

@@ -27,10 +27,12 @@ public function tearDown() {
 		WC_Helper_Product::delete_product( $this->product->get_id() );
 	}
 
-	public function test_build_shipment_contents_simple_product_no_dimensions() {
+	public function test_build_shipment_contents_simple_product_no_weight() {
 		$this->product = WC_Helper_Product::create_simple_product();
+		$product_id = $this->product->get_id();
+		update_post_meta( $product_id, '_weight', '' );
 
-		WC()->cart->add_to_cart( $this->product->get_id(), 1 );
+		WC()->cart->add_to_cart( $product_id, 1 );
 
 		$actual = $this->api_client->build_shipment_contents( array( 'contents' => WC()->cart->get_cart() ) );