Send Update-Activity when "Actor-Mode" is changed (#1342)

* Send Update-Activity when "Actor-Mode" is changed

fix #1339

* update changelog

* delete defaults

* Fix tests

* Add phpdoc

Author: pfefferle

CHANGELOG.md

@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Setting to adjust the number of days Outbox items are kept before being purged.
 * Undo API for Outbox items.
 * Metadata to New Follower E-Mail.
+* Allow Activities on URLs instead of requiring Activity-Objects. This is useful especially for sending Announces and Likes.
 
 ### Changed
 
@@ -22,8 +23,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 * The Outbox purging routine no longer is limited to deleting 5 items at a time.
-* Allow Activities on URLs instead of requiring Activity-Objects. This is useful especially for sending Announces and Likes.
 * Ellipses now display correctly in notification emails for Likes and Reposts.
+* Send Update-Activity when "Actor-Mode" is changed.
 
 ## [5.2.0] - 2025-02-13
 

includes/scheduler/class-actor.php

@@ -43,6 +43,9 @@ public static function init() {
 			// @todo figure out a feasible way of updating the header image since it's not unique to any user.
 		}
 
+		\add_action( 'add_option_activitypub_actor_mode', array( self::class, 'blog_user_update' ) );
+		\add_action( 'update_option_activitypub_actor_mode', array( self::class, 'blog_user_update' ) );
+
 		\add_action( 'transition_post_status', array( self::class, 'schedule_post_activity' ), 33, 3 );
 	}
 
@@ -67,6 +70,7 @@ public static function user_meta_update( $meta_id, $user_id, $meta_key ) {
 			'user_url',
 			'display_name',
 		);
+
 		if ( in_array( $meta_key, $fields, true ) ) {
 			self::schedule_profile_update( $user_id );
 		}

readme.txt

@@ -139,8 +139,9 @@ For reasons of data protection, it is not possible to see the followers of other
 * Changed: Outbox now precesses the first batch of followers right away to avoid delays in processing new Activities.
 * Changed: Post bulk edits no longer create Outbox items, unless author or post status change.
 * Fixed: The Outbox purging routine no longer is limited to deleting 5 items at a time.
-* Fixed an issue where the outbox could not send object types other than `Base_Object` (introduced in 5.0.0).
+* Fixed: An issue where the outbox could not send object types other than `Base_Object` (introduced in 5.0.0).
 * Fixed: Ellipses now display correctly in notification emails for Likes and Reposts.
+* Fixed: Send Update-Activity when "Actor-Mode" is changed.
 
 = 5.2.0 =
 

tests/includes/class-test-signature.php

@@ -16,6 +16,22 @@
  * @coversDefaultClass \Activitypub\Signature
  */
 class Test_Signature extends \WP_UnitTestCase {
+	/**
+	 * Tear down.
+	 */
+	public function tear_down() {
+		parent::tear_down();
+		\delete_option( 'activitypub_keypair_for_0' );
+		\delete_option( 'activitypub_keypair_for_-1' );
+		\delete_option( 'activitypub_keypair_for_admin' );
+		\delete_option( 'activitypub_blog_user_public_key' );
+		\delete_option( 'activitypub_blog_user_private_key' );
+		\delete_option( 'activitypub_application_user_public_key' );
+		\delete_option( 'activitypub_application_user_private_key' );
+		\delete_option( 'activitypub_actor_mode' );
+		\delete_user_meta( 1, 'magic_sig_public_key' );
+		\delete_user_meta( 1, 'magic_sig_private_key' );
+	}
 
 	/**
 	 * Test signature creation.
@@ -45,6 +61,8 @@ public function test_signature_legacy() {
 		// Check user.
 		$user = Actors::get_by_id( 1 );
 
+		\delete_option( 'activitypub_keypair_for_admin' );
+
 		$public_key  = 'public key ' . $user->get__id();
 		$private_key = 'private key ' . $user->get__id();
 
@@ -60,11 +78,13 @@ public function test_signature_legacy() {
 		// Check application user.
 		$user = Actors::get_by_id( Actors::APPLICATION_USER_ID );
 
+		\delete_option( 'activitypub_keypair_for_-1' );
+
 		$public_key  = 'public key ' . $user->get__id();
 		$private_key = 'private key ' . $user->get__id();
 
-		add_option( 'activitypub_application_user_public_key', $public_key );
-		add_option( 'activitypub_application_user_private_key', $private_key );
+		\add_option( 'activitypub_application_user_public_key', $public_key );
+		\add_option( 'activitypub_application_user_private_key', $private_key );
 
 		$key_pair = Signature::get_keypair_for( $user->get__id() );
 
@@ -80,8 +100,10 @@ public function test_signature_legacy() {
 		$public_key  = 'public key ' . $user->get__id();
 		$private_key = 'private key ' . $user->get__id();
 
-		add_option( 'activitypub_blog_user_public_key', $public_key );
-		add_option( 'activitypub_blog_user_private_key', $private_key );
+		\delete_option( 'activitypub_keypair_for_0' );
+
+		\add_option( 'activitypub_blog_user_public_key', $public_key );
+		\add_option( 'activitypub_blog_user_private_key', $private_key );
 
 		$key_pair = Signature::get_keypair_for( $user->get__id() );