NodeInfo: Make sure usage data has correct format (#1667)

Author: obenland

.github/changelog/1667-from-description

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+NodeInfo endpoint response now correctly formats `localPosts` values.

includes/rest/class-nodeinfo-controller.php

@@ -159,7 +159,7 @@ public function get_version_2_0() {
 					'activeHalfyear' => get_active_users( 6 ),
 					'activeMonth'    => get_active_users(),
 				),
-				'localPosts'    => $posts->publish,
+				'localPosts'    => (int) $posts->publish,
 				'localComments' => $comments->approved,
 			),
 			'metadata'          => array(

tests/includes/rest/class-test-nodeinfo-controller.php

@@ -73,6 +73,9 @@ public function test_get_items() {
 	 * @covers ::get_version_2_0
 	 */
 	public function test_get_item() {
+		self::factory()->post->create();
+		self::factory()->comment->create();
+
 		$request  = new \WP_REST_Request( 'GET', '/' . ACTIVITYPUB_REST_NAMESPACE . '/nodeinfo/2.0' );
 		$response = \rest_get_server()->dispatch( $request );
 		$data     = $response->get_data();
@@ -85,8 +88,9 @@ public function test_get_item() {
 		$this->assertEquals( array( 'activitypub' ), $data['protocols'] );
 		$this->assertArrayHasKey( 'services', $data );
 		$this->assertEquals( (bool) \get_option( 'users_can_register' ), $data['openRegistrations'] );
-		$this->assertArrayHasKey( 'usage', $data );
-		$this->assertArrayHasKey( 'metadata', $data );
+		$this->assertIsInt( $data['usage']['localPosts'] );
+		$this->assertIsInt( $data['usage']['localComments'] );
+		$this->assertSame( \get_bloginfo( 'name' ), $data['metadata']['nodeName'] );
 	}
 
 	/**