Ensure that all schedulers are registered (#1959)

pfefferle · web-flow · commit 3b058697fb9a · 2025-07-18T17:44:58.000+02:00
diff --git a/.github/changelog/1959-from-description b/.github/changelog/1959-from-description
@@ -0,0 +1,4 @@
+Significance: minor
+Type: added
+
+Ensure that all schedulers are registered during every plugin update.
diff --git a/includes/class-migration.php b/includes/class-migration.php
@@ -160,14 +160,10 @@ public static function maybe_migrate() {
 			add_action( 'init', 'flush_rewrite_rules', 20 );
 		}
 		if ( \version_compare( $version_from_db, '5.0.0', '<' ) ) {
-			Scheduler::register_schedules();
 			\wp_schedule_single_event( \time(), 'activitypub_upgrade', array( 'create_post_outbox_items' ) );
 			\wp_schedule_single_event( \time() + 15, 'activitypub_upgrade', array( 'create_comment_outbox_items' ) );
 			add_action( 'init', 'flush_rewrite_rules', 20 );
 		}
-		if ( \version_compare( $version_from_db, '5.2.0', '<' ) ) {
-			Scheduler::register_schedules();
-		}
 		if ( \version_compare( $version_from_db, '5.4.0', '<' ) ) {
 			\wp_schedule_single_event( \time(), 'activitypub_upgrade', array( 'update_actor_json_slashing' ) );
 			\wp_schedule_single_event( \time(), 'activitypub_upgrade', array( 'update_comment_author_emails' ) );
@@ -203,6 +199,9 @@ public static function maybe_migrate() {
 			}
 		}
 
+		// Ensure all required cron schedules are registered.
+		Scheduler::register_schedules();
+
 		/*
 		 * Add new update routines above this comment. ^
 		 *

Original file line number	Diff line number	Diff line change
`@@ -160,14 +160,10 @@ public static function maybe_migrate() {`
`160`	`160`	`add_action( 'init', 'flush_rewrite_rules', 20 );`
`161`	`161`	`}`
`162`	`162`	`if ( \version_compare( $version_from_db, '5.0.0', '<' ) ) {`
`163`		`- Scheduler::register_schedules();`
`164`	`163`	`\wp_schedule_single_event( \time(), 'activitypub_upgrade', array( 'create_post_outbox_items' ) );`
`165`	`164`	`\wp_schedule_single_event( \time() + 15, 'activitypub_upgrade', array( 'create_comment_outbox_items' ) );`
`166`	`165`	`add_action( 'init', 'flush_rewrite_rules', 20 );`
`167`	`166`	`}`
`168`		`- if ( \version_compare( $version_from_db, '5.2.0', '<' ) ) {`
`169`		`- Scheduler::register_schedules();`
`170`		`- }`
`171`	`167`	`if ( \version_compare( $version_from_db, '5.4.0', '<' ) ) {`
`172`	`168`	`\wp_schedule_single_event( \time(), 'activitypub_upgrade', array( 'update_actor_json_slashing' ) );`
`173`	`169`	`\wp_schedule_single_event( \time(), 'activitypub_upgrade', array( 'update_comment_author_emails' ) );`
`@@ -203,6 +199,9 @@ public static function maybe_migrate() {`
`203`	`199`	`}`
`204`	`200`	`}`
`205`	`201`
	`202`	`+ // Ensure all required cron schedules are registered.`
	`203`	`+ Scheduler::register_schedules();`
	`204`	`+`
`206`	`205`	`/*`
`207`	`206`	`* Add new update routines above this comment. ^`
`208`	`207`	`*`