Janitorial: Fix PHP Warnings (#1127)

obenland · web-flow · commit 3dac6c178709 · 2025-01-06T10:22:02.000-06:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+
+### Fixed
+
+* Undefined array key warnings in various places
+
 ## [4.6.0] - 2024-12-20
 
 ### Added
diff --git a/includes/collection/class-interactions.php b/includes/collection/class-interactions.php
@@ -246,10 +246,10 @@ public static function activity_to_comment( $activity ) {
 			return false;
 		}
 
-		$url = object_to_uri( $actor['url'] );
+		$url = object_to_uri( $actor['url'] ?? $actor['id'] );
 
 		if ( ! $url ) {
-			object_to_uri( $actor['id'] );
+			$url = object_to_uri( $actor['id'] );
 		}
 
 		if ( isset( $activity['object']['content'] ) ) {
diff --git a/includes/transformer/class-post.php b/includes/transformer/class-post.php
@@ -1114,7 +1114,7 @@ public function get_in_reply_to() {
 		$blocks = \parse_blocks( $this->wp_object->post_content );
 
 		foreach ( $blocks as $block ) {
-			if ( 'activitypub/reply' === $block['blockName'] ) {
+			if ( 'activitypub/reply' === $block['blockName'] && isset( $block['attrs']['url'] ) ) {
 				// We only support one reply block per post for now.
 				return $block['attrs']['url'];
 			}
diff --git a/readme.txt b/readme.txt
@@ -132,6 +132,10 @@ For reasons of data protection, it is not possible to see the followers of other
 
 == Changelog ==
 
+= Unreleased =
+
+* Fixed: Undefined array key warnings in various places
+
 = 4.6.0 =
 
 * Added: A filter to allow modifying the ActivityPub preview template
diff --git a/templates/post-preview.php b/templates/post-preview.php
@@ -179,7 +179,7 @@
 	<body>
 		<div class="columns">
 			<aside class="sidebar">
-				<input type="search" disabled="disabled" placeholder="<?php echo esc_html_e( 'Search', 'activitypub' ); ?>" disabled="disabled" />
+				<input type="search" disabled="disabled" placeholder="<?php esc_html_e( 'Search', 'activitypub' ); ?>" />
 				<div>
 					<div class="fake-image"></div>
 					<div>
@@ -218,7 +218,7 @@
 					<div class="attachments">
 						<?php foreach ( $object->get_attachment() as $attachment ) : ?>
 							<?php if ( 'Image' === $attachment['type'] ) : ?>
-								<img src="<?php echo esc_url( $attachment['url'] ); ?>" alt="<?php echo esc_attr( $attachment['name'] ); ?>" />
+								<img src="<?php echo esc_url( $attachment['url'] ); ?>" alt="<?php echo esc_attr( $attachment['name'] ?? '' ); ?>" />
 							<?php endif; ?>
 						<?php endforeach; ?>
 					</div>

Original file line number	Diff line number	Diff line change
`@@ -246,10 +246,10 @@ public static function activity_to_comment( $activity ) {`
`246`	`246`	`return false;`
`247`	`247`	`}`
`248`	`248`
`249`		`- $url = object_to_uri( $actor['url'] );`
	`249`	`+ $url = object_to_uri( $actor['url'] ?? $actor['id'] );`
`250`	`250`
`251`	`251`	`if ( ! $url ) {`
`252`		`- object_to_uri( $actor['id'] );`
	`252`	`+ $url = object_to_uri( $actor['id'] );`
`253`	`253`	`}`
`254`	`254`
`255`	`255`	`if ( isset( $activity['object']['content'] ) ) {`
Original file line number	Diff line number	Diff line change
`@@ -1114,7 +1114,7 @@ public function get_in_reply_to() {`
`1114`	`1114`	`$blocks = \parse_blocks( $this->wp_object->post_content );`
`1115`	`1115`
`1116`	`1116`	`foreach ( $blocks as $block ) {`
`1117`		`- if ( 'activitypub/reply' === $block['blockName'] ) {`
	`1117`	`+ if ( 'activitypub/reply' === $block['blockName'] && isset( $block['attrs']['url'] ) ) {`
`1118`	`1118`	`// We only support one reply block per post for now.`
`1119`	`1119`	`return $block['attrs']['url'];`
`1120`	`1120`	`}`