Fix fatal error when Remote_Actors::get_actor() encounters WP_Error

pfefferle · pfefferle · commit 695d46067f08 · 2025-12-21T11:41:51.000+01:00
When Actor::init_from_json() returns a WP_Error (e.g., due to corrupted or invalid JSON data), the code logged the error but continued executing, then tried calling get_webfinger() on the WP_Error object, causing a fatal error. Fixes #2675
diff --git a/.github/changelog/fix-remote-actor-wp-error-handling b/.github/changelog/fix-remote-actor-wp-error-handling
@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+Fix fatal error when Remote_Actors::get_actor() encounters invalid actor JSON data.
diff --git a/includes/collection/class-remote-actors.php b/includes/collection/class-remote-actors.php
@@ -471,6 +471,7 @@ public static function get_actor( $post ) {
 
 		if ( \is_wp_error( $actor ) ) {
 			self::add_error( $post->ID, $actor );
+			return $actor;
 		}
 
 		if ( ! $actor->get_webfinger() ) {

Original file line number	Diff line number	Diff line change
`@@ -471,6 +471,7 @@ public static function get_actor( $post ) {`
`471`	`471`
`472`	`472`	`if ( \is_wp_error( $actor ) ) {`
`473`	`473`	`self::add_error( $post->ID, $actor );`
	`474`	`+ return $actor;`
`474`	`475`	`}`
`475`	`476`
`476`	`477`	`if ( ! $actor->get_webfinger() ) {`