Rename is_activity_quote to is_quote_activity

Refactored the function is_activity_quote to is_quote_activity for improved naming consistency. Updated all references and related tests to use the new function name.

Author: pfefferle

includes/functions.php

@@ -630,7 +630,7 @@ function is_activity_reply( $data ) {
  *
  * @return boolean True if a quote, false if not.
  */
-function is_activity_quote( $data ) {
+function is_quote_activity( $data ) {
 	return ! empty( $data['object']['quote'] ) ||
 		! empty( $data['object']['quoteUrl'] ) ||
 		! empty( $data['object']['quoteUri'] ) ||

includes/handler/class-create.php

@@ -11,8 +11,8 @@
 use Activitypub\Collection\Posts;
 
 use function Activitypub\get_activity_visibility;
-use function Activitypub\is_activity_quote;
 use function Activitypub\is_activity_reply;
+use function Activitypub\is_quote_activity;
 use function Activitypub\is_self_ping;
 use function Activitypub\object_id_to_comment;
 
@@ -39,7 +39,7 @@ public static function handle_create( $activity, $user_ids, $activity_object = n
 		// Check for private and/or direct messages.
 		if ( ACTIVITYPUB_CONTENT_VISIBILITY_PRIVATE === get_activity_visibility( $activity ) ) {
 			$result = false;
-		} elseif ( is_activity_reply( $activity ) || is_activity_quote( $activity ) ) { // Check for replies and quotes.
+		} elseif ( is_activity_reply( $activity ) || is_quote_activity( $activity ) ) { // Check for replies and quotes.
 			$result = self::create_interaction( $activity, $user_ids, $activity_object );
 		} elseif ( \get_option( 'activitypub_create_posts', false ) ) { // Handle non-interaction objects.
 			$result = self::create_post( $activity, $user_ids, $activity_object );

tests/phpunit/tests/includes/class-test-functions.php

@@ -1562,11 +1562,11 @@ public function test_is_activity_reply_returns_false_for_non_reply() {
 	}
 
 	/**
-	 * Test is_activity_quote function with quote property.
+	 * Test is_quote_activity function with quote property.
 	 *
-	 * @covers \Activitypub\is_activity_quote
+	 * @covers \Activitypub\is_quote_activity
 	 */
-	public function test_is_activity_quote_with_quote() {
+	public function test_is_quote_activity_with_quote() {
 		$activity = array(
 			'type'   => 'Create',
 			'object' => array(
@@ -1576,15 +1576,15 @@ public function test_is_activity_quote_with_quote() {
 			),
 		);
 
-		$this->assertTrue( \Activitypub\is_activity_quote( $activity ) );
+		$this->assertTrue( \Activitypub\is_quote_activity( $activity ) );
 	}
 
 	/**
-	 * Test is_activity_quote function with quoteUrl property.
+	 * Test is_quote_activity function with quoteUrl property.
 	 *
-	 * @covers \Activitypub\is_activity_quote
+	 * @covers \Activitypub\is_quote_activity
 	 */
-	public function test_is_activity_quote_with_quote_url() {
+	public function test_is_quote_activity_with_quote_url() {
 		$activity = array(
 			'type'   => 'Create',
 			'object' => array(
@@ -1594,15 +1594,15 @@ public function test_is_activity_quote_with_quote_url() {
 			),
 		);
 
-		$this->assertTrue( \Activitypub\is_activity_quote( $activity ) );
+		$this->assertTrue( \Activitypub\is_quote_activity( $activity ) );
 	}
 
 	/**
-	 * Test is_activity_quote function with quoteUri property.
+	 * Test is_quote_activity function with quoteUri property.
 	 *
-	 * @covers \Activitypub\is_activity_quote
+	 * @covers \Activitypub\is_quote_activity
 	 */
-	public function test_is_activity_quote_with_quote_uri() {
+	public function test_is_quote_activity_with_quote_uri() {
 		$activity = array(
 			'type'   => 'Create',
 			'object' => array(
@@ -1612,15 +1612,15 @@ public function test_is_activity_quote_with_quote_uri() {
 			),
 		);
 
-		$this->assertTrue( \Activitypub\is_activity_quote( $activity ) );
+		$this->assertTrue( \Activitypub\is_quote_activity( $activity ) );
 	}
 
 	/**
-	 * Test is_activity_quote function with _misskey_quote property.
+	 * Test is_quote_activity function with _misskey_quote property.
 	 *
-	 * @covers \Activitypub\is_activity_quote
+	 * @covers \Activitypub\is_quote_activity
 	 */
-	public function test_is_activity_quote_with_misskey_quote() {
+	public function test_is_quote_activity_with_misskey_quote() {
 		$activity = array(
 			'type'   => 'Create',
 			'object' => array(
@@ -1630,15 +1630,15 @@ public function test_is_activity_quote_with_misskey_quote() {
 			),
 		);
 
-		$this->assertTrue( \Activitypub\is_activity_quote( $activity ) );
+		$this->assertTrue( \Activitypub\is_quote_activity( $activity ) );
 	}
 
 	/**
-	 * Test is_activity_quote returns false for non-quote.
+	 * Test is_quote_activity returns false for non-quote.
 	 *
-	 * @covers \Activitypub\is_activity_quote
+	 * @covers \Activitypub\is_quote_activity
 	 */
-	public function test_is_activity_quote_returns_false_for_non_quote() {
+	public function test_is_quote_activity_returns_false_for_non_quote() {
 		$activity = array(
 			'type'   => 'Create',
 			'object' => array(
@@ -1647,6 +1647,6 @@ public function test_is_activity_quote_returns_false_for_non_quote() {
 			),
 		);
 
-		$this->assertFalse( \Activitypub\is_activity_quote( $activity ) );
+		$this->assertFalse( \Activitypub\is_quote_activity( $activity ) );
 	}
 }