Enhance keyword blocking to support content maps (#2093)

Author: pfefferle

.github/changelog/2093-from-description

@@ -0,0 +1,4 @@
+Significance: minor
+Type: added
+
+Moderation now checks blocked keywords across all language variants of the content, summary and name fields.

includes/activity/class-generic-object.php

@@ -25,17 +25,20 @@
  * @method array[]|null            get_attachment()         Gets the attachment property of the object.
  * @method string[]|null           get_cc()                 Gets the secondary recipients of the object.
  * @method string|null             get_content()            Gets the content property of the object.
+ * @method string[]|null           get_content_map()        Gets the content map property of the object.
  * @method string[]|null           get_endpoints()          Gets the endpoint property of the object.
  * @method string[]|null           get_icon()               Gets the icon property of the object.
  * @method string|null             get_id()                 Gets the object's unique global identifier.
  * @method string[]|null           get_image()              Gets the image property of the object.
  * @method string[]|string|null    get_in_reply_to()        Gets the objects this object is in reply to.
  * @method string|null             get_inbox()              Gets the inbox property of the object.
  * @method string|null             get_name()               Gets the natural language name of the object.
+ * @method string[]|null           get_name_map()           Gets the name map property of the object.
  * @method Base_Object|string|null get_object()             Gets the direct object of the activity.
  * @method string|null             get_preferred_username() Gets the preferred username of the object.
  * @method string|null             get_published()          Gets the date and time the object was published in ISO 8601 format.
  * @method string|null             get_summary()            Gets the natural language summary of the object.
+ * @method string[]|null           get_summary_map()        Gets the summary map property of the object.
  * @method array[]|null            get_tag()                Gets the tag property of the object.
  * @method string[]|string|null    get_to()                 Gets the primary recipients of the object.
  * @method string                  get_type()               Gets the type of the object.

includes/class-moderation.php

@@ -242,11 +242,31 @@ private static function check_activity_against_blocks( $activity, $blocked_actor
 
 		// Check blocked keywords in activity content.
 		if ( $has_object ) {
-			$content = $activity->get_object()->get_content() . ' ' . $activity->get_object()->get_summary() . ' ' . $activity->get_object()->get_name();
-			if ( is_actor( $activity->get_object() ) ) {
-				$content .= ' ' . $activity->get_object()->get_preferred_username();
+			$object        = $activity->get_object();
+			$content_map   = array();
+			$content_map[] = $object->get_content();
+			$content_map[] = $object->get_summary();
+			$content_map[] = $object->get_name();
+
+			if ( is_actor( $object ) ) {
+				$content_map[] = $object->get_preferred_username();
 			}
 
+			if ( \is_array( $object->get_content_map() ) ) {
+				$content_map = \array_merge( $content_map, \array_values( $object->get_content_map() ) );
+			}
+
+			if ( \is_array( $object->get_summary_map() ) ) {
+				$content_map = \array_merge( $content_map, \array_values( $object->get_summary_map() ) );
+			}
+
+			if ( \is_array( $object->get_name_map() ) ) {
+				$content_map = \array_merge( $content_map, \array_values( $object->get_name_map() ) );
+			}
+
+			$content_map = \array_filter( $content_map );
+			$content     = \implode( ' ', $content_map );
+
 			foreach ( $blocked_keywords as $keyword ) {
 				if ( \stripos( $content, $keyword ) !== false ) {
 					return true;

tests/includes/class-test-moderation.php

@@ -288,6 +288,24 @@ public function test_activity_is_blocked_site_wide() {
 		);
 		$this->assertTrue( Moderation::activity_is_blocked( $activity ) );
 
+		// Test keyword blocking.
+		/* @var Activity $activity Activity. */
+		$activity = Activity::init_from_array(
+			array(
+				'type'   => 'Create',
+				'actor'  => 'https://good.example.com/@user',
+				'object' => array(
+					'id'          => 'https://example.com/note/1',
+					'type'        => 'Note',
+					'content_map' => array(
+						'en' => 'Check out this product, buy now!',
+						'de' => 'Überprüfe dieses Produkt, kaufe jetzt!',
+					),
+				),
+			)
+		);
+		$this->assertTrue( Moderation::activity_is_blocked( $activity ) );
+
 		// Test non-blocked activity.
 		/* @var Activity $activity Activity. */
 		$activity = Activity::init_from_array(