Fix NodeInfo rel (#1275)

* Fix NodeInfo rel

* fix tests

Author: pfefferle

CHANGELOG.md

@@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Cleanup of option values when the plugin is uninstalled.
 * Third-party plugins can filter settings tabs to add their own settings pages for ActivityPub.
 * Show ActivityPub preview in row actions when Block Editor is enabled but not used for the post type.
-*
+
 ### Changed
 
 * Manually granting `activitypub` cap no longer requires the receiving user to have `publish_post`.
@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Negotiation of ActivityPub requests for custom post types when queried by the ActivityPub ID.
 * Avoid PHP warnings when using Debug mode and when the `actor` is not set.
 * No longer creates Outbox items when importing content/users.
+* Fix NodeInfo 2.0 URL to be HTTP instead of HTTPS.
 
 ## [5.0.0] - 2025-02-03
 

includes/rest/class-nodeinfo-controller.php

@@ -79,6 +79,10 @@ public function register_routes() {
 	public function get_items( $request ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
 		$response = array(
 			'links' => array(
+				array(
+					'rel'  => 'http://nodeinfo.diaspora.software/ns/schema/2.0',
+					'href' => get_rest_url_by_path( '/nodeinfo/2.0' ),
+				),
 				array(
 					'rel'  => 'https://nodeinfo.diaspora.software/ns/schema/2.0',
 					'href' => get_rest_url_by_path( '/nodeinfo/2.0' ),

readme.txt

@@ -143,6 +143,7 @@ For reasons of data protection, it is not possible to see the followers of other
 * Fixed: Negotiation of ActivityPub requests for custom post types when queried by the ActivityPub ID.
 * Fixed: Avoid PHP warnings when using Debug mode and when the `actor` is not set.
 * Fixed: No longer creates Outbox items when importing content/users.
+* Fixed: NodeInfo 2.0 URL to be HTTP instead of HTTPS.
 
 = 5.0.0 =
 

tests/includes/rest/class-test-nodeinfo-controller.php

@@ -40,12 +40,16 @@ public function test_get_items() {
 		$this->assertCount( 3, $data['links'] );
 
 		// Test first link.
-		$this->assertEquals( 'https://nodeinfo.diaspora.software/ns/schema/2.0', $data['links'][0]['rel'] );
+		$this->assertEquals( 'http://nodeinfo.diaspora.software/ns/schema/2.0', $data['links'][0]['rel'] );
 		$this->assertStringEndsWith( '/nodeinfo/2.0', $data['links'][0]['href'] );
 
 		// Test second link.
-		$this->assertEquals( 'https://www.w3.org/ns/activitystreams#Application', $data['links'][1]['rel'] );
-		$this->assertStringEndsWith( '/application', $data['links'][1]['href'] );
+		$this->assertEquals( 'https://nodeinfo.diaspora.software/ns/schema/2.0', $data['links'][1]['rel'] );
+		$this->assertStringEndsWith( '/nodeinfo/2.0', $data['links'][1]['href'] );
+
+		// Test third link.
+		$this->assertEquals( 'https://www.w3.org/ns/activitystreams#Application', $data['links'][2]['rel'] );
+		$this->assertStringEndsWith( '/application', $data['links'][2]['href'] );
 
 		// Make sure the links work.
 		$request  = new \WP_REST_Request( 'GET', str_replace( \get_rest_url(), '/', $data['links'][0]['href'] ) );