Fix deprecated notices in PHP 8 (#1544)

* Fix deprecated notices in PHP 8

* Fix another one

Author: obenland

includes/class-sanitize.php

@@ -24,8 +24,8 @@ public static function url_list( $value ) {
 			$value = \explode( PHP_EOL, $value );
 		}
 
-		$value = \array_map( 'trim', $value );
 		$value = \array_filter( $value );
+		$value = \array_map( 'trim', $value );
 		$value = \array_map( 'sanitize_url', $value );
 		$value = \array_unique( $value );
 

tests/includes/class-test-migration.php

@@ -610,8 +610,10 @@ public function test_update_actor_json_slashing() {
 		$follower = new Follower();
 		$follower->from_array(
 			array(
-				'type'    => 'Person',
-				'summary' => '<p>unescaped backslash 04\2024</p>',
+				'type'               => 'Person',
+				'name'               => 'Test Follower',
+				'preferred_username' => 'Follower',
+				'summary'            => '<p>unescaped backslash 04\2024</p>',
 			)
 		);
 		$unslashed_json = $follower->to_json();

tests/includes/class-test-scheduler.php

@@ -56,9 +56,15 @@ public static function wpTearDownAfterClass() {
 	public function test_reprocess_outbox() {
 		// Create test activity objects.
 		$activity = new Activity();
-		$activity->set_object( array( 'content' => 'Test Content' ) );
 		$activity->set_type( 'Create' );
 		$activity->set_id( 'https://example.com/test-id' );
+		$activity->set_object(
+			array(
+				'id'      => 'https://example.com/test-id',
+				'type'    => 'Note',
+				'content' => 'Test Content',
+			)
+		);
 
 		// Add multiple pending activities.
 		$pending_ids = array();
@@ -149,9 +155,15 @@ function ( $event ) use ( &$scheduled_events ) {
 	public function test_reprocess_outbox_scheduling() {
 		// Create a test activity.
 		$activity = new Activity();
-		$activity->set_object( array( 'content' => 'Test Content' ) );
 		$activity->set_type( 'Create' );
 		$activity->set_id( 'https://example.com/test-id' );
+		$activity->set_object(
+			array(
+				'id'      => 'https://example.com/test-id',
+				'type'    => 'Note',
+				'content' => 'Test Content',
+			)
+		);
 
 		$pending_id = Outbox::add( $activity, self::$user_id );