Register post types and meta on 'init' action (#2232)

Author: pfefferle

.github/changelog/2232-from-description

@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+Fixed an issue where post metadata in the block editor was missing or failed to update.

includes/class-post-types.php

@@ -22,11 +22,11 @@ class Post_Types {
 	 * Initialize the class, registering all custom post types and post meta.
 	 */
 	public static function init() {
-		self::register_remote_actors_post_type();
-		self::register_inbox_post_type();
-		self::register_outbox_post_type();
-		self::register_extra_fields_post_types();
-		self::register_activitypub_post_meta();
+		\add_action( 'init', array( self::class, 'register_remote_actors_post_type' ), 11 );
+		\add_action( 'init', array( self::class, 'register_inbox_post_type' ), 11 );
+		\add_action( 'init', array( self::class, 'register_outbox_post_type' ), 11 );
+		\add_action( 'init', array( self::class, 'register_extra_fields_post_types' ), 11 );
+		\add_action( 'init', array( self::class, 'register_activitypub_post_meta' ), 11 );
 
 		\add_action( 'rest_api_init', array( self::class, 'register_ap_actor_rest_field' ) );
 
@@ -529,20 +529,20 @@ public static function default_post_meta_data( $meta_value, $object_id, $meta_ke
 		}
 
 		// If meta value is already explicitly set, respect the author's choice.
-		if ( null !== $meta_value ) {
+		if ( $meta_value ) {
 			return $meta_value;
 		}
 
 		// If the post is federated, return the default visibility.
 		if ( 'federated' === \get_post_meta( $object_id, 'activitypub_status', true ) ) {
-			return null;
+			return $meta_value;
 		}
 
 		// If the post is not federated and older than a month, return local visibility.
 		if ( \get_the_date( 'U', $object_id ) < \strtotime( '-1 month' ) ) {
 			return ACTIVITYPUB_CONTENT_VISIBILITY_LOCAL;
 		}
 
-		return null;
+		return $meta_value;
 	}
 }

tests/includes/class-test-post-types.php

@@ -85,8 +85,8 @@ public function test_get_post_metadata() {
 
 		// Test 5: When meta value is already set (not null), should respect author's explicit choice.
 		\update_post_meta( $post_id, 'activitypub_status', 'pending' ); // Ensure not federated.
-		$result = Post_Types::default_post_meta_data( ACTIVITYPUB_CONTENT_VISIBILITY_PUBLIC, $post_id, 'activitypub_content_visibility' );
-		$this->assertEquals( ACTIVITYPUB_CONTENT_VISIBILITY_PUBLIC, $result, 'Should respect explicitly set public visibility even for old unfederated posts.' );
+		$result = Post_Types::default_post_meta_data( ACTIVITYPUB_CONTENT_VISIBILITY_QUIET_PUBLIC, $post_id, 'activitypub_content_visibility' );
+		$this->assertEquals( ACTIVITYPUB_CONTENT_VISIBILITY_QUIET_PUBLIC, $result, 'Should respect explicitly set public visibility even for old unfederated posts.' );
 
 		// Test 6: Only apply local visibility when meta value is null (no explicit setting).
 		$result = Post_Types::default_post_meta_data( null, $post_id, 'activitypub_content_visibility' );