Blocks: Avoid PHP warning in Reply block (#1076)

* Blocks: Avoid PHP warning in Reply block

* Fix phpcs

I wish Cursor AI knew WP coding standards

---------

Co-authored-by: Matthias Pfefferle <[email protected]>

Author: obenland

CHANGELOG.md

@@ -20,6 +20,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Improve Interactions moderation
 * Compatibility with Akismet
 
+### Fixed
+
+* Empty `url` attributes in the Reply block no longer cause PHP warnings
+
 ## [4.4.0] - 2024-12-09
 
 ### Added

includes/class-blocks.php

@@ -305,23 +305,25 @@ function ( $follower ) {
 	 * @return string The HTML to render.
 	 */
 	public static function render_reply_block( $attrs ) {
+		$html = '';
+
+		if ( ! empty( $attrs['url'] ) ) {
+			$html = sprintf(
+				'<p><a title="%2$s" aria-label="%2$s" href="%1$s" class="u-in-reply-to" target="_blank">%3$s</a></p>',
+				esc_url( $attrs['url'] ),
+				esc_attr__( 'This post is a response to the referenced content.', 'activitypub' ),
+				// translators: %s is the URL of the post being replied to.
+				sprintf( __( '&#8620;%s', 'activitypub' ), \str_replace( array( 'https://', 'http://' ), '', esc_url( $attrs['url'] ) ) )
+			);
+		}
+
 		/**
 		 * Filter the reply block.
 		 *
 		 * @param string $html  The HTML to render.
 		 * @param array  $attrs The block attributes.
 		 */
-		return apply_filters(
-			'activitypub_reply_block',
-			sprintf(
-				'<p><a title="%2$s" aria-label="%2$s" href="%1$s" class="u-in-reply-to" target="_blank">%3$s</a></p>',
-				esc_url( $attrs['url'] ),
-				esc_attr__( 'This post is a response to the referenced content.', 'activitypub' ),
-				// translators: %s is the URL of the post being replied to.
-				sprintf( __( '&#8620;%s', 'activitypub' ), \str_replace( array( 'https://', 'http://' ), '', $attrs['url'] ) )
-			),
-			$attrs
-		);
+		return apply_filters( 'activitypub_reply_block', $html, $attrs );
 	}
 
 	/**

readme.txt

@@ -141,6 +141,7 @@ For reasons of data protection, it is not possible to see the followers of other
 * Improved: Email templates for Likes and Reposts
 * Improved: Interactions moderation
 * Improved: Compatibility with Akismet
+* Fixed: Empty `url` attributes in the Reply block no longer cause PHP warnings
 
 = 4.4.0 =
 

tests/includes/class-test-blocks.php

@@ -0,0 +1,51 @@
+<?php
+/**
+ * Test file for Blocks class.
+ *
+ * @package Activitypub
+ */
+
+namespace Activitypub\Tests;
+
+/**
+ * Test class for Blocks.
+ *
+ * @coversDefaultClass \Activitypub\Blocks
+ */
+class Test_Blocks extends \WP_UnitTestCase {
+
+	/**
+	 * Test the render_reply_block() method with a valid URL attribute.
+	 *
+	 * @covers ::render_reply_block
+	 */
+	public function test_render_reply_block_with_valid_url() {
+		$attrs  = array( 'url' => 'https://example.com/post' );
+		$output = \Activitypub\Blocks::render_reply_block( $attrs );
+		$this->assertStringContainsString( 'u-in-reply-to', $output );
+		$this->assertStringContainsString( 'https://example.com/post', $output );
+		$this->assertStringContainsString( 'example.com/post', $output );
+	}
+
+	/**
+	 * Test the render_reply_block() method with a missing URL attribute.
+	 *
+	 * @covers ::render_reply_block
+	 */
+	public function test_render_reply_block_with_missing_url() {
+		$attrs  = array();
+		$output = \Activitypub\Blocks::render_reply_block( $attrs );
+		$this->assertEmpty( $output );
+	}
+
+	/**
+	 * Test the render_reply_block() method with an empty URL attribute.
+	 *
+	 * @covers ::render_reply_block
+	 */
+	public function test_render_reply_block_with_empty_url() {
+		$attrs  = array( 'url' => '' );
+		$output = \Activitypub\Blocks::render_reply_block( $attrs );
+		$this->assertEmpty( $output );
+	}
+}