Reply: Normalize for Pleroma (#1799)

Author: obenland

.github/changelog/1799-from-description

@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+Webfinger data from Pleroma instances no longer creates unexpected mention markup.

includes/transformer/class-post.php

@@ -581,7 +581,7 @@ public function generate_reply_link( $block_content, $block ) {
 		// Get webfinger identifier.
 		$webfinger = '';
 		if ( ! empty( $author['webfinger'] ) ) {
-			$webfinger = $author['webfinger'];
+			$webfinger = \str_replace( 'acct:', '', $author['webfinger'] );
 		} elseif ( ! empty( $author['preferredUsername'] ) && ! empty( $author['url'] ) ) {
 			// Construct webfinger-style identifier from username and domain.
 			$domain    = \wp_parse_url( $author['url'], PHP_URL_HOST );

tests/includes/transformer/class-test-post.php

@@ -8,7 +8,6 @@
 namespace Activitypub\Tests\Transformer;
 
 use Activitypub\Transformer\Post;
-use ReflectionClass;
 
 /**
  * Test class for Post Transformer.
@@ -19,7 +18,7 @@ class Test_Post extends \WP_UnitTestCase {
 	/**
 	 * Reflection method for testing protected method.
 	 *
-	 * @var ReflectionMethod
+	 * @var \ReflectionMethod
 	 */
 	private $reflection_method;
 
@@ -32,7 +31,7 @@ public function set_up() {
 		update_option( 'activitypub_object_type', 'wordpress-post-format' );
 
 		// Set up reflection method.
-		$reflection              = new ReflectionClass( Post::class );
+		$reflection              = new \ReflectionClass( Post::class );
 		$this->reflection_method = $reflection->getMethod( 'get_type' );
 		$this->reflection_method->setAccessible( true );
 	}
@@ -654,4 +653,50 @@ public function test_preview_property() {
 		// Check if the preview for a Note is null.
 		$this->assertNull( $note_preview );
 	}
+
+	/**
+	 * Test reply link generation.
+	 *
+	 * Pleroma prepends `acct:` to the webfinger identifier, which we'd want to normalize.
+	 *
+	 * @covers ::generate_reply_link
+	 */
+	public function test_generate_reply_link() {
+		\add_filter( 'activitypub_pre_http_get_remote_object', array( $this, 'filter_pleroma_object' ), 10, 2 );
+
+		$transformer = new Post( self::factory()->post->create_and_get() );
+		$reply_link  = $transformer->generate_reply_link( '', array( 'attrs' => array( 'url' => 'https://devs.live/notice/AQ8N0Xl57y8bUQAb6e' ) ) );
+
+		$this->assertSame( '<p class="ap-reply-mention"><a rel="mention ugc" href="https://devs.live/notice/AQ8N0Xl57y8bUQAb6e" title="[email protected]">@tester</a></p>', $reply_link );
+
+		\remove_filter( 'activitypub_pre_http_get_remote_object', array( $this, 'filter_pleroma_object' ) );
+	}
+
+	/**
+	 * Filter pleroma object.
+	 *
+	 * @param array|string|null $response The response.
+	 * @param array|string|null $url      The Object URL.
+	 * @return string[]
+	 */
+	public function filter_pleroma_object( $response, $url ) {
+		if ( 'https://devs.live/notice/AQ8N0Xl57y8bUQAb6e' === $url ) {
+			$response = array(
+				'type'         => 'Note',
+				'attributedTo' => 'https://devs.live/users/tester',
+				'content'      => 'Cake day it is',
+			);
+		}
+		if ( 'https://devs.live/users/tester' === $url ) {
+			$response = array(
+				'id'                => 'https://devs.live/users/tester',
+				'type'              => 'Person',
+				'preferredUsername' => 'tester',
+				'url'               => 'https://devs.live/users/tester',
+				'webfinger'         => 'acct:[email protected]',
+			);
+		}
+
+		return $response;
+	}
 }