Application Actor: Set manuallyApprovesFollowers property to true (#2113)

Author: pfefferle

.github/changelog/2113-from-description

@@ -0,0 +1,4 @@
+Significance: minor
+Type: changed
+
+Improved ActivityPub compatibility by aligning with Mastodon’s Application Actor.

includes/activity/class-actor.php

@@ -27,6 +27,7 @@ class Actor extends Base_Object {
 			'schema'                    => 'http://schema.org#',
 			'toot'                      => 'http://joinmastodon.org/ns#',
 			'lemmy'                     => 'https://join-lemmy.org/ns#',
+			'litepub'                   => 'http://litepub.social/ns#',
 			'manuallyApprovesFollowers' => 'as:manuallyApprovesFollowers',
 			'PropertyValue'             => 'schema:PropertyValue',
 			'value'                     => 'schema:value',
@@ -63,6 +64,7 @@ class Actor extends Base_Object {
 			'postingRestrictedToMods'   => 'lemmy:postingRestrictedToMods',
 			'discoverable'              => 'toot:discoverable',
 			'indexable'                 => 'toot:indexable',
+			'invisible'                 => 'litepub:invisible',
 		),
 	);
 
@@ -312,4 +314,13 @@ class Actor extends Base_Object {
 	 * @var array
 	 */
 	protected $implements;
+
+	/**
+	 * Whether the User is invisible.
+	 *
+	 * @see https://litepub.social/
+	 *
+	 * @var boolean
+	 */
+	protected $invisible = null;
 }

includes/model/class-application.php

@@ -33,7 +33,7 @@ class Application extends Actor {
 	 *
 	 * @context http://joinmastodon.org/ns#discoverable
 	 *
-	 * @var boolean
+	 * @var bool
 	 */
 	protected $discoverable = false;
 
@@ -42,10 +42,21 @@ class Application extends Actor {
 	 *
 	 * @context http://joinmastodon.org/ns#indexable
 	 *
-	 * @var boolean
+	 * @var bool
 	 */
 	protected $indexable = false;
 
+	/**
+	 * Whether the Application manually approves followers.
+	 *
+	 * @see https://docs.joinmastodon.org/spec/activitypub/#as
+	 *
+	 * @context as:manuallyApprovesFollowers
+	 *
+	 * @var bool
+	 */
+	protected $manually_approves_followers = true;
+
 	/**
 	 * List of software capabilities implemented by the Application.
 	 *
@@ -61,22 +72,34 @@ class Application extends Actor {
 	);
 
 	/**
-	 * Returns the type of the object.
+	 * Set Application as invisible.
+	 *
+	 * @see https://litepub.social/
+	 *
+	 * @var bool
+	 */
+	protected $invisible = true;
+
+	/**
+	 * The type of the Actor.
 	 *
-	 * @return string The type of the object.
+	 * @var string
 	 */
-	public function get_type() {
-		return 'Application';
-	}
+	protected $type = 'Application';
 
 	/**
-	 * Returns whether the Application manually approves followers.
+	 * The Username.
 	 *
-	 * @return true Whether the Application manually approves followers.
+	 * @var string
 	 */
-	public function get_manually_approves_followers() {
-		return true;
-	}
+	protected $name = 'application';
+
+	/**
+	 * The preferred username.
+	 *
+	 * @var string
+	 */
+	protected $preferred_username = 'application';
 
 	/**
 	 * Returns the ID of the Application.
@@ -105,24 +128,6 @@ public function get_alternate_url() {
 		return $this->get_id();
 	}
 
-	/**
-	 * Get the Username.
-	 *
-	 * @return string The Username.
-	 */
-	public function get_name() {
-		return 'application';
-	}
-
-	/**
-	 * Get the preferred username.
-	 *
-	 * @return string The preferred username.
-	 */
-	public function get_preferred_username() {
-		return $this->get_name();
-	}
-
 	/**
 	 * Get the User-Icon.
 	 *