Add: New Health checks (#1524)

* Add: New Health checks

To improve the onboarding experience!

* no need to deactivate crons

* explain the issue with threaded comments

* Add changelog

* fix phpcs issues

* Update includes/wp-admin/class-health-check.php

Co-authored-by: Konstantin Obenland <[email protected]>

* Update includes/wp-admin/class-health-check.php

Co-authored-by: Konstantin Obenland <[email protected]>

* simplify text

props @obenland

* Update includes/wp-admin/class-health-check.php

Co-authored-by: Konstantin Obenland <[email protected]>

* Update includes/wp-admin/class-health-check.php

Co-authored-by: Konstantin Obenland <[email protected]>

---------

Co-authored-by: Konstantin Obenland <[email protected]>

Author: pfefferle

.github/changelog/1524-from-description

@@ -0,0 +1,4 @@
+Significance: minor
+Type: added
+
+Check if pretty permalinks are enabled and recommend to use threaded comments.

includes/wp-admin/class-health-check.php

@@ -94,6 +94,16 @@ public static function add_tests( $tests ) {
 			'test'  => array( self::class, 'test_webfinger' ),
 		);
 
+		$tests['direct']['activitypub_test_threaded_comments'] = array(
+			'label' => \__( 'Threaded Comments Test', 'activitypub' ),
+			'test'  => array( self::class, 'test_threaded_comments' ),
+		);
+
+		$tests['direct']['activitypub_test_pretty_permalinks'] = array(
+			'label' => \__( 'Pretty Permalinks Test', 'activitypub' ),
+			'test'  => array( self::class, 'test_pretty_permalinks' ),
+		);
+
 		return $tests;
 	}
 
@@ -135,49 +145,6 @@ public static function test_author_url() {
 		return $result;
 	}
 
-	/**
-	 * System Cron tests.
-	 *
-	 * @return array The test result.
-	 */
-	public static function test_system_cron() {
-		$result = array(
-			'label'       => \__( 'System Task Scheduler configured', 'activitypub' ),
-			'status'      => 'good',
-			'badge'       => array(
-				'label' => \__( 'ActivityPub', 'activitypub' ),
-				'color' => 'green',
-			),
-			'description' => \sprintf(
-				'<p>%s</p>',
-				\esc_html__( 'You seem to use the System Task Scheduler to process WP_Cron tasks.', 'activitypub' )
-			),
-			'actions'     => '',
-			'test'        => 'test_system_cron',
-		);
-
-		if ( defined( 'DISABLE_WP_CRON' ) && DISABLE_WP_CRON ) {
-			return $result;
-		}
-
-		$result['status']         = 'recommended';
-		$result['label']          = \__( 'System Task Scheduler not configured', 'activitypub' );
-		$result['badge']['color'] = 'orange';
-		$result['description']    = \sprintf(
-			'<p>%s</p>',
-			\__( 'Enhance your WordPress site’s performance and mitigate potential heavy loads caused by plugins like ActivityPub by setting up a system cron job to run WP Cron. This ensures scheduled tasks are executed consistently and reduces the reliance on website traffic for trigger events.', 'activitypub' )
-		);
-		$result['actions']       .= sprintf(
-			'<p><a href="%s" target="_blank" rel="noopener">%s<span class="screen-reader-text"> %s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a></p>',
-			esc_url( __( 'https://developer.wordpress.org/plugins/cron/hooking-wp-cron-into-the-system-task-scheduler/', 'activitypub' ) ),
-			__( 'Learn how to hook the WP-Cron into the System Task Scheduler.', 'activitypub' ),
-			/* translators: Hidden accessibility text. */
-			__( '(opens in a new tab)', 'activitypub' )
-		);
-
-		return $result;
-	}
-
 	/**
 	 * WebFinger tests.
 	 *
@@ -379,4 +346,82 @@ public static function debug_information( $info ) {
 
 		return $info;
 	}
+
+	/**
+	 * Threaded Comments tests.
+	 *
+	 * @return array The test result.
+	 */
+	public static function test_threaded_comments() {
+		$result = array(
+			'label'       => \__( 'Threaded (nested) comments enabled', 'activitypub' ),
+			'status'      => 'good',
+			'badge'       => array(
+				'label' => \__( 'ActivityPub', 'activitypub' ),
+				'color' => 'green',
+			),
+			'description' => \sprintf(
+				'<p>%s</p>',
+				\__( 'Threaded (nested) comments are enabled.', 'activitypub' )
+			),
+			'actions'     => '',
+			'test'        => 'test_threaded_comments',
+		);
+
+		if ( '1' !== get_option( 'thread_comments', '0' ) ) {
+			$result['status']         = 'recommended';
+			$result['label']          = \__( 'Threaded (nested) comments are not enabled', 'activitypub' );
+			$result['badge']['color'] = 'orange';
+			$result['description']    = \sprintf(
+				'<p>%s</p><p>%s</p>',
+				\__( 'This is particularly important for fediverse users, as they rely on the visual hierarchy to understand conversation threads across different platforms. Without threaded comments, it becomes much more difficult to follow discussions that span multiple platforms in the fediverse.', 'activitypub' ),
+				\sprintf(
+					// translators: %s: Discussion settings URL.
+					\__( 'You can enable them in the <a href="%s">Discussion Settings</a>.', 'activitypub' ),
+					esc_url( admin_url( 'options-discussion.php' ) )
+				)
+			);
+		}
+
+		return $result;
+	}
+
+	/**
+	 * Pretty Permalinks tests.
+	 *
+	 * @return array The test result.
+	 */
+	public static function test_pretty_permalinks() {
+		$result = array(
+			'label'       => \__( 'Pretty Permalinks enabled', 'activitypub' ),
+			'status'      => 'good',
+			'badge'       => array(
+				'label' => \__( 'ActivityPub', 'activitypub' ),
+				'color' => 'green',
+			),
+			'description' => \sprintf(
+				'<p>%s</p>',
+				\__( 'Your pretty permalinks are enabled and working correctly.', 'activitypub' )
+			),
+			'actions'     => '',
+			'test'        => 'test_pretty_permalinks',
+		);
+
+		$permalink_structure = \get_option( 'permalink_structure' );
+		if ( empty( $permalink_structure ) ) {
+			$result['status']         = 'critical';
+			$result['label']          = \__( 'Pretty Permalinks are not enabled.', 'activitypub' );
+			$result['badge']['color'] = 'red';
+			$result['description']    = \sprintf(
+				'<p>%s</p>',
+				sprintf(
+					/* translators: %s: Permalink settings URL. */
+					\__( 'ActivityPub needs SEO-friendly URLs to work properly. Please <a href="%s">update your permalink structure</a> to an option other than Plain.', 'activitypub' ),
+					esc_url( admin_url( 'options-permalink.php' ) )
+				)
+			);
+		}
+
+		return $result;
+	}
 }