Allow short ternary (Elvis) operator in codebase #2436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all inline phpcs ignore comments for the Universal.Operators.DisallowShortTernary rule and updates phpcs.xml to exclude this rule, permitting use of the short ternary (Elvis) operator throughout the codebase.
pfefferle
added
[Type] Janitorial
Skip Changelog
github-actions
bot
added
[Feature] Collections
[Focus] Compatibility
There was a problem hiding this comment.
Pull Request Overview
This PR enables the use of short ternary operators (Elvis operator ?:) in the codebase by excluding the Universal.Operators.DisallowShortTernary PHPCS rule and removing all the phpcs:ignore comments that were previously needed to suppress warnings for this pattern.
Key Changes:
- Updated PHPCS configuration to allow short ternary operators
- Removed 11
phpcs:ignorecomments across 8 files where the Elvis operator is used
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| phpcs.xml | Added rule exclusion for Universal.Operators.DisallowShortTernary to allow Elvis operator usage |
| integration/class-wp-rest-cache.php | Removed phpcs:ignore comment for Elvis operator in comment type validation |
| integration/class-classic-editor.php | Removed phpcs:ignore comment for Elvis operator when setting default quote interaction policy |
| includes/transformer/class-post.php | Removed phpcs:ignore comment for Elvis operator when retrieving post content template |
| includes/model/class-user.php | Removed phpcs:ignore comment for Elvis operator when getting also known as values |
| includes/collection/class-inbox.php | Removed two phpcs:ignore comments for Elvis operators used in title retrieval |
| includes/class-move.php | Removed phpcs:ignore comment for Elvis operator when updating also known as values |
| includes/class-moderation.php | Removed four phpcs:ignore comments for Elvis operators in user block management |
| includes/class-avatars.php | Removed phpcs:ignore comment for Elvis operator in comment type validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
obenland
previously approved these changes
Nov 10, 2025
Deleted redundant 'phpcs:ignore Universal.Operators.DisallowShortTernary.Found' comments from multiple files after excluding the rule in phpcs.xml. This cleans up the code and maintains consistency with the project's coding standards configuration.
github-actions
bot
added
[Block] Followers
[Feature] WP Admin
[Focus] Editor
Member
Author
|
@obenland btw. is the short-ternary operator allowed on WP.com? |
Member
Author
|
It is not allowed on WP.com, so we have to keep it as is. |
Member
We could add an exception for the activitypub plugin folder in the global phpcs.xml on Dotcom. There's precedent. |
- Consolidate duplicate WordPress ruleset references into single block with exclusion - Remove standalone PHPCompatibility rule (included in PHPCompatibilityWP) - Reorganize config values for better readability
obenland
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all inline phpcs ignore comments for the Universal.Operators.DisallowShortTernary rule and updates phpcs.xml to exclude this rule, permitting use of the short ternary (Elvis) operator throughout the codebase.
Proposed changes:
phpcs:ignorecomments across 8 files where the Elvis operator is usedOther information:
Testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message