Skip to content

Conversation

@obenland
Copy link
Member

Proposed changes:

This PR implements a comprehensive skill system to provide context-aware documentation for development workflows:

  • activitypub-dev-cycle: Environment setup, testing, linting, and builds
  • activitypub-php-conventions: WordPress coding standards and patterns
  • activitypub-pr-workflow: PR creation and review processes
  • activitypub-federation: ActivityPub protocol specification
  • activitypub-testing: PHPUnit and Playwright test patterns
  • activitypub-release: Version management and releases
  • activitypub-integrations: Third-party plugin integration

Skills use cross-references to reduce duplication while maintaining context-appropriate information. Federation skill focuses on protocol understanding rather than implementation details.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Review the new .claude/skills/ directory structure
  • Verify each skill file has appropriate content and cross-references
  • Check that .gitignore properly tracks skills while ignoring *.local.* files
  • Review CLAUDE.md for documentation on the skills system

This implements a comprehensive skill system to provide context-aware
documentation for development workflows:

- activitypub-dev-cycle: Environment setup, testing, linting, and builds
- activitypub-php-conventions: WordPress coding standards and patterns
- activitypub-pr-workflow: PR creation and review processes
- activitypub-federation: ActivityPub protocol specification
- activitypub-testing: PHPUnit and Playwright test patterns
- activitypub-release: Version management and releases
- activitypub-integrations: Third-party plugin integration

Skills use cross-references to reduce duplication while maintaining
context-appropriate information. Federation skill focuses on protocol
understanding rather than implementation details.

Updates .gitignore to track shared skills while ignoring local overrides
using the *.local.* pattern.
@obenland obenland self-assigned this Nov 13, 2025
@obenland obenland requested a review from a team November 13, 2025 00:49
@obenland
Copy link
Member Author

@pfefferle This will need some more work and polish, there's also still a lot of overlap. I'm curious if this would be helpful to make Claude work better for us. Curious for your feedback/thoughts.

See
https://www.claude.com/blog/skills
https://www.anthropic.com/engineering/equipping-agents-for-the-real-world-with-agent-skills
https://docs.claude.com/en/docs/agents-and-tools/agent-skills/overview

@pfefferle
Copy link
Member

pfefferle commented Nov 13, 2025

I’m not entirely convinced yet. I like the idea of improving how we use AI, but I’d prefer a more generic approach. We’re both using Claude right now, but that could change, and I don’t think we should have to rebuild this whole structure every time we switch models.

On top of that, the examples, class structure, and coding standards files feel like they duplicate what already exists in the codebase. The examples and structure are already reflected in the code, and our coding standards are defined in .editorconfig and phpcs.xml. Keeping separate files for all of this means they’ll need to be updated every time we make structural changes, which adds unnecessary maintenance overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants