Properly handle IO-related HTTP errors (#705)

These should mostly just emit the IO error’s underlying message, so we do that for all IO errors that don’t have a specific override

Author: jkmassel

wp_api/src/reqwest_request_executor.rs

@@ -187,35 +187,22 @@ impl From<reqwest::Error> for RequestExecutionError {
 
         if let Some(io_error) = error.as_io_error() {
             match io_error.kind() {
-                std::io::ErrorKind::ConnectionRefused => {
-                    return RequestExecutionError::RequestExecutionFailed {
-                        status_code,
-                        redirects: None,
-                        reason: RequestExecutionErrorReason::NonExistentSiteError {
-                            error_message: Some("Connection refused".to_string()),
-                            suggested_action: None,
-                        },
-                    };
-                }
                 std::io::ErrorKind::UnexpectedEof => {
                     // Server terminated the connection unexpectedly
                     return RequestExecutionError::RequestExecutionFailed {
                         status_code,
                         redirects: None,
-                        reason: RequestExecutionErrorReason::NonExistentSiteError {
-                            error_message: Some(
-                                "The server terminated the connection unexpectedly".to_string(),
-                            ),
-                            suggested_action: None,
+                        reason: RequestExecutionErrorReason::HttpError {
+                            reason: "The server terminated the connection unexpectedly".to_string(),
                         },
                     };
                 }
                 _ => {
                     return RequestExecutionError::RequestExecutionFailed {
                         status_code,
                         redirects: None,
-                        reason: RequestExecutionErrorReason::GenericError {
-                            error_message: error.to_string(),
+                        reason: RequestExecutionErrorReason::HttpError {
+                            reason: io_error.to_string(),
                         },
                     };
                 }

wp_rs_cli/src/bin/wp_rs_cli/main.rs

@@ -182,7 +182,7 @@ impl SimplifiedDiscoveryResult {
                 println!("{}", format!("Login URL found: {login_url}").green());
             }
             Err(error) => {
-                println!("{}", format!("Error: {}", error).red());
+                println!("{}", error.to_string().red());
             }
         }
     }