Improve error messaging for some connection errors (#700)

* Improve error messaging for some connection errors

* Properly handle Kotlin `NoRouteToHostException`

* Update wp_localization/localization/tr-TR/main.ftl

Co-authored-by: Oguz Kocer <[email protected]>

---------

Co-authored-by: Oguz Kocer <[email protected]>

Author: jkmassel

native/kotlin/api/kotlin/src/main/kotlin/rs/wordpress/api/kotlin/WpRequestExecutor.kt

@@ -22,6 +22,7 @@ import uniffi.wp_api.WpNetworkRequest
 import uniffi.wp_api.WpNetworkResponse
 import uniffi.wp_api.parseCertificate
 import java.io.File
+import java.net.NoRouteToHostException
 import java.net.UnknownHostException
 import javax.net.ssl.HttpsURLConnection
 import javax.net.ssl.SSLPeerUnverifiedException
@@ -67,6 +68,8 @@ class WpRequestExecutor(
                 )
             } catch (e: UnknownHostException) {
                 throw requestExecutionFailedWith(RequestExecutionErrorReason.unknownHost(e))
+            } catch (e: NoRouteToHostException) {
+                throw requestExecutionFailedWith(RequestExecutionErrorReason.noRouteToHost(e))
             }
         }
 
@@ -122,6 +125,11 @@ private fun RequestExecutionErrorReason.Companion.unknownHost(e: UnknownHostExce
         suggestedAction = "Check that the URL is valid and try again"
     )
 
+private fun RequestExecutionErrorReason.Companion.noRouteToHost(e: NoRouteToHostException) =
+    RequestExecutionErrorReason.HttpError(
+        reason = e.localizedMessage
+    )
+
 @Suppress("UNUSED_PARAMETER")
 private fun RequestExecutionErrorReason.Companion.invalidSSLError(
     e: SSLPeerUnverifiedException, // To avoid `SwallowedException` from Detekt

wp_api/src/api_error.rs

@@ -497,6 +497,9 @@ pub enum RequestExecutionErrorReason {
     DeviceIsOfflineError {
         error_message: String,
     },
+    HttpError {
+        reason: String,
+    },
     GenericError {
         error_message: String,
     },
@@ -577,6 +580,9 @@ impl WpSupportsLocalization for RequestExecutionErrorReason {
             RequestExecutionErrorReason::DeviceIsOfflineError { error_message } => {
                 WpMessages::just(error_message)
             }
+            RequestExecutionErrorReason::HttpError { reason } => {
+                WpMessages::http_server_error(reason)
+            }
             RequestExecutionErrorReason::GenericError { error_message } => {
                 WpMessages::just(error_message)
             }

wp_api/src/reqwest_request_executor.rs

@@ -285,12 +285,15 @@ impl From<&ResolveError> for RequestExecutionErrorReason {
 impl From<&HyperError> for RequestExecutionErrorReason {
     fn from(error: &HyperError) -> Self {
         if let Some(http2_error) = error.find::<Http2Error>() {
-            // TODO: We can probably handle more cases here, such as:
-            // - Connection reset
-
-            return RequestExecutionErrorReason::GenericError {
-                error_message: http2_error.to_string(),
-            };
+            if let Some(reason) = http2_error.reason() {
+                return RequestExecutionErrorReason::HttpError {
+                    reason: reason.description().to_string(),
+                };
+            } else {
+                return RequestExecutionErrorReason::GenericError {
+                    error_message: http2_error.to_string(),
+                };
+            }
         }
 
         if error.is_closed() {

wp_localization/localization/en-US/main.ftl

@@ -25,6 +25,8 @@ http_timeout_error = The connection timed out
 
 http_authentication_rejected_error = The server at {$url} rejected your credentials. Please provide a valid username and password.
 
+http_server_error = Unable to connect to server: {$reason}. Please contact your server provider.
+
 misconfigured_http_authentication_error = The server is sending invalid HTTP authentication information. Please check your site's HTTP authentication configuration.
 
 misconfigured_rate_limit_error = The server is rate limiting requests in a way that will never succeed. Please check your site's rate limit configuration.