Generate AppendUrlQueryPairs & FromUrlQueryPairs trait implementations from WpDeriveParamsField (#871)

* Add pagination attribute parsing and comprehensive error handling

Implement #[pagination(true/false)] container attribute support for
WpDeriveParamsField macro with complete error validation.

Changes:
- Register pagination attribute in proc_macro_derive definition
- Add pagination parsing logic with proper boolean value validation
- Update ParsedParamsStruct to include pagination field for future trait generation
- Add field_type to ParsedField for upcoming automatic type detection
- Implement comprehensive error handling for all pagination scenarios
- Add complete test coverage for all error cases

New error types:
- PaginationAttributeRequired: when #[pagination] is missing
- DuplicatePaginationAttribute: when multiple #[pagination] exist
- PaginationRequiresValue: when #[pagination] has no value
- PaginationMustBeBool: when #[pagination] value is not boolean

Test coverage: 6 tests (2 passing, 4 error scenarios)

* Implement AppendUrlQueryPairs and FromUrlQueryPairs trait generation

Complete the WpDeriveParamsField macro by adding automatic trait implementations
for URL query parameter handling.

Changes:
- Add AppendUrlQueryPairs trait implementation generation with automatic method selection
- Add FromUrlQueryPairs trait implementation with pagination support
- Implement type detection for Option<T>, Vec<T>, and Option<WpGmtDateTime> fields
- Use proc_macro_crate to resolve correct module paths for trait references
- Make generated enum public for external access
- Add comprehensive unit tests for type detection logic

* Rename pagination attribute to supports_pagination

Update all references from #[pagination] to #[supports_pagination] for clarity.

Changes:
- Update attribute name constant and error messages
- Update all test files to use new attribute name
- Update expected error messages in stderr files

* Replace manual trait implementations with macro-generated traits

Complete the migration from manual AppendUrlQueryPairs and FromUrlQueryPairs
implementations to macro-generated ones for all standard parameter structs.

Changes:
- Add #[supports_pagination(true/false)] attributes based on existing supports_pagination() methods
- Remove all manual AppendUrlQueryPairs and FromUrlQueryPairs implementations
- Keep users.rs with manual implementation (requires override attributes for WpApiParamUsersWho)
- Net result: -461 lines of boilerplate code, +12 lines of attributes

All files now use macro-generated traits except users.rs which needs special handling.
The macro correctly handles:
- Option<T> fields -> get() and append_option_query_value_pair()
- Vec<T> fields -> get_csv() and append_vec_query_value_pair()
- Option<WpGmtDateTime> fields -> get_wp_date_time() and append_option_query_value_pair()
- Custom field names via #[field_name("name")] attributes

* Fix wp_derive tests with minimal mock trait implementations

Add minimal mock trait and method implementations to test files to enable
compilation and testing of the macro-generated code.

Changes:
- Add minimal AppendUrlQueryPairs and FromUrlQueryPairs traits
- Add mock QueryPairs and UrlQueryPairsMap structs
- Add required method implementations with minimal signatures
- Tests now pass and validate macro functionality without requiring wp_api dependency

All wp_derive tests now pass: ✅

* Add override attributes support for WpDeriveParamsField macro

Implement `from_query_method` and `append_query_custom` attributes
to handle special field mappings that require custom serialization.

Changes:
- Add parsing for `from_query_method` and `append_query_custom` attributes
- Update macro to generate custom method calls when overrides are specified
- Replace manual UserListParams trait implementations with macro-generated ones
- Add special handling for `who` field using override attributes
- All existing tests pass confirming backward compatibility

* Fix clippy warnings in WpDeriveParamsField macro

Address clippy issues identified in cargo clippy --tests:

Changes:
- Remove redundant enum variant prefixes (AppendQueryMethod variants)
- Collapse nested if statements in is_wp_date_time_option method using let-chain patterns
- Update all enum variant references and test assertions

* Update MediaListParams test expectations to match generated field order

Fix failing tests by updating expected query parameter ordering to match
the macro-generated trait implementations which follow struct field order.

Changes:
- Move parent_exclude parameter to appear directly after parent parameter
- Update both media.rs and media_endpoint.rs test expectations
- No functional change - only reordering of query string parameters
- All 812 unit tests now pass

The generated macro correctly follows MediaListParams struct field order:
parent → parent_exclude → search_columns → slug → status

Author: oguzkocer

wp_api/src/categories.rs

@@ -40,6 +40,7 @@ pub enum WpApiParamCategoriesOrderBy {
 impl_as_query_value_from_to_string!(WpApiParamCategoriesOrderBy);
 
 #[derive(Debug, Default, PartialEq, Eq, uniffi::Record, WpDeriveParamsField)]
+#[supports_pagination(true)]
 pub struct CategoryListParams {
     /// Current page of the collection.
     /// Default: `1`
@@ -86,53 +87,6 @@ pub struct CategoryListParams {
     pub slug: Vec<String>,
 }
 
-impl AppendUrlQueryPairs for CategoryListParams {
-    fn append_query_pairs(&self, query_pairs_mut: &mut QueryPairs) {
-        query_pairs_mut
-            .append_option_query_value_pair(CategoryListParamsField::Page, self.page.as_ref())
-            .append_option_query_value_pair(
-                CategoryListParamsField::PerPage,
-                self.per_page.as_ref(),
-            )
-            .append_option_query_value_pair(CategoryListParamsField::Search, self.search.as_ref())
-            .append_vec_query_value_pair(CategoryListParamsField::Exclude, &self.exclude)
-            .append_vec_query_value_pair(CategoryListParamsField::Include, &self.include)
-            .append_option_query_value_pair(CategoryListParamsField::Offset, self.offset.as_ref())
-            .append_option_query_value_pair(CategoryListParamsField::Order, self.order.as_ref())
-            .append_option_query_value_pair(CategoryListParamsField::Orderby, self.orderby.as_ref())
-            .append_option_query_value_pair(
-                CategoryListParamsField::HideEmpty,
-                self.hide_empty.as_ref(),
-            )
-            .append_option_query_value_pair(CategoryListParamsField::Parent, self.parent.as_ref())
-            .append_option_query_value_pair(CategoryListParamsField::Post, self.post.as_ref())
-            .append_vec_query_value_pair(CategoryListParamsField::Slug, &self.slug);
-    }
-}
-
-impl FromUrlQueryPairs for CategoryListParams {
-    fn from_url_query_pairs(query_pairs: UrlQueryPairsMap) -> Option<Self> {
-        Some(Self {
-            page: query_pairs.get(CategoryListParamsField::Page),
-            per_page: query_pairs.get(CategoryListParamsField::PerPage),
-            search: query_pairs.get(CategoryListParamsField::Search),
-            exclude: query_pairs.get_csv(CategoryListParamsField::Exclude),
-            include: query_pairs.get_csv(CategoryListParamsField::Include),
-            offset: query_pairs.get(CategoryListParamsField::Offset),
-            order: query_pairs.get(CategoryListParamsField::Order),
-            orderby: query_pairs.get(CategoryListParamsField::Orderby),
-            hide_empty: query_pairs.get(CategoryListParamsField::HideEmpty),
-            parent: query_pairs.get(CategoryListParamsField::Parent),
-            post: query_pairs.get(CategoryListParamsField::Post),
-            slug: query_pairs.get_csv(CategoryListParamsField::Slug),
-        })
-    }
-
-    fn supports_pagination() -> bool {
-        true
-    }
-}
-
 #[derive(Debug, Serialize, Deserialize, uniffi::Record)]
 pub struct CategoryDeleteResponse {
     pub deleted: bool,

wp_api/src/comments.rs

@@ -70,6 +70,7 @@ pub enum CommentType {
 impl_as_query_value_from_to_string!(CommentType);
 
 #[derive(Debug, Default, PartialEq, Eq, uniffi::Record, WpDeriveParamsField)]
+#[supports_pagination(true)]
 pub struct CommentListParams {
     /// Current page of the collection.
     /// Default: `1`
@@ -140,76 +141,6 @@ pub struct CommentListParams {
     pub password: Option<String>,
 }
 
-impl AppendUrlQueryPairs for CommentListParams {
-    fn append_query_pairs(&self, query_pairs_mut: &mut QueryPairs) {
-        query_pairs_mut
-            .append_option_query_value_pair(CommentListParamsField::Page, self.page.as_ref())
-            .append_option_query_value_pair(CommentListParamsField::PerPage, self.per_page.as_ref())
-            .append_option_query_value_pair(CommentListParamsField::Search, self.search.as_ref())
-            .append_option_query_value_pair(CommentListParamsField::After, self.after.as_ref())
-            .append_vec_query_value_pair(CommentListParamsField::Author, &self.author)
-            .append_vec_query_value_pair(
-                CommentListParamsField::AuthorExclude,
-                &self.author_exclude,
-            )
-            .append_option_query_value_pair(
-                CommentListParamsField::AuthorEmail,
-                self.author_email.as_ref(),
-            )
-            .append_option_query_value_pair(CommentListParamsField::Before, self.before.as_ref())
-            .append_vec_query_value_pair(CommentListParamsField::Exclude, &self.exclude)
-            .append_vec_query_value_pair(CommentListParamsField::Include, &self.include)
-            .append_option_query_value_pair(CommentListParamsField::Offset, self.offset.as_ref())
-            .append_option_query_value_pair(CommentListParamsField::Order, self.order.as_ref())
-            .append_option_query_value_pair(CommentListParamsField::Orderby, self.orderby.as_ref())
-            .append_vec_query_value_pair(CommentListParamsField::Parent, self.parent.as_ref())
-            .append_vec_query_value_pair(
-                CommentListParamsField::ParentExclude,
-                self.parent_exclude.as_ref(),
-            )
-            .append_vec_query_value_pair(CommentListParamsField::Post, self.post.as_ref())
-            .append_option_query_value_pair(CommentListParamsField::Status, self.status.as_ref())
-            .append_option_query_value_pair(
-                CommentListParamsField::CommentType,
-                self.comment_type.as_ref(),
-            )
-            .append_option_query_value_pair(
-                CommentListParamsField::Password,
-                self.password.as_ref(),
-            );
-    }
-}
-
-impl FromUrlQueryPairs for CommentListParams {
-    fn from_url_query_pairs(query_pairs: UrlQueryPairsMap) -> Option<Self> {
-        Some(Self {
-            page: query_pairs.get(CommentListParamsField::Page),
-            per_page: query_pairs.get(CommentListParamsField::PerPage),
-            search: query_pairs.get(CommentListParamsField::Search),
-            after: query_pairs.get(CommentListParamsField::After),
-            author: query_pairs.get_csv(CommentListParamsField::Author),
-            author_exclude: query_pairs.get_csv(CommentListParamsField::AuthorExclude),
-            author_email: query_pairs.get(CommentListParamsField::AuthorEmail),
-            before: query_pairs.get(CommentListParamsField::Before),
-            exclude: query_pairs.get_csv(CommentListParamsField::Exclude),
-            include: query_pairs.get_csv(CommentListParamsField::Include),
-            offset: query_pairs.get(CommentListParamsField::Offset),
-            order: query_pairs.get(CommentListParamsField::Order),
-            orderby: query_pairs.get(CommentListParamsField::Orderby),
-            parent: query_pairs.get_csv(CommentListParamsField::Parent),
-            parent_exclude: query_pairs.get_csv(CommentListParamsField::ParentExclude),
-            post: query_pairs.get_csv(CommentListParamsField::Post),
-            status: query_pairs.get(CommentListParamsField::Status),
-            comment_type: query_pairs.get(CommentListParamsField::CommentType),
-            password: query_pairs.get(CommentListParamsField::Password),
-        })
-    }
-
-    fn supports_pagination() -> bool {
-        true
-    }
-}
-
 #[derive(Debug, Default, uniffi::Record)]
 pub struct CommentRetrieveParams {
     /// The password for the parent post of the comment (if the post is password protected).

wp_api/src/media.rs

@@ -108,6 +108,7 @@ pub enum MediaStatus {
 impl_as_query_value_from_to_string!(MediaStatus);
 
 #[derive(Debug, Default, PartialEq, Eq, uniffi::Record, WpDeriveParamsField)]
+#[supports_pagination(true)]
 pub struct MediaListParams {
     /// Current page of the collection.
     /// Default: `1`
@@ -183,80 +184,6 @@ pub struct MediaListParams {
     pub mime_type: Option<String>,
 }
 
-impl AppendUrlQueryPairs for MediaListParams {
-    fn append_query_pairs(&self, query_pairs_mut: &mut QueryPairs) {
-        query_pairs_mut
-            .append_option_query_value_pair(MediaListParamsField::Page, self.page.as_ref())
-            .append_option_query_value_pair(MediaListParamsField::PerPage, self.per_page.as_ref())
-            .append_option_query_value_pair(MediaListParamsField::Search, self.search.as_ref())
-            .append_option_query_value_pair(MediaListParamsField::After, self.after.as_ref())
-            .append_option_query_value_pair(
-                MediaListParamsField::ModifiedAfter,
-                self.modified_after.as_ref(),
-            )
-            .append_vec_query_value_pair(MediaListParamsField::Author, &self.author)
-            .append_vec_query_value_pair(MediaListParamsField::AuthorExclude, &self.author_exclude)
-            .append_option_query_value_pair(MediaListParamsField::Before, self.before.as_ref())
-            .append_option_query_value_pair(
-                MediaListParamsField::ModifiedBefore,
-                self.modified_before.as_ref(),
-            )
-            .append_vec_query_value_pair(MediaListParamsField::Exclude, &self.exclude)
-            .append_vec_query_value_pair(MediaListParamsField::Include, &self.include)
-            .append_option_query_value_pair(MediaListParamsField::Offset, self.offset.as_ref())
-            .append_option_query_value_pair(MediaListParamsField::Order, self.order.as_ref())
-            .append_option_query_value_pair(MediaListParamsField::Orderby, self.orderby.as_ref())
-            .append_vec_query_value_pair(MediaListParamsField::Parent, self.parent.as_ref())
-            .append_vec_query_value_pair(MediaListParamsField::SearchColumns, &self.search_columns)
-            .append_vec_query_value_pair(MediaListParamsField::Slug, &self.slug)
-            .append_vec_query_value_pair(MediaListParamsField::Status, &self.status)
-            .append_vec_query_value_pair(
-                MediaListParamsField::ParentExclude,
-                self.parent_exclude.as_ref(),
-            )
-            .append_option_query_value_pair(
-                MediaListParamsField::MediaType,
-                self.media_type.as_ref(),
-            )
-            .append_option_query_value_pair(
-                MediaListParamsField::MimeType,
-                self.mime_type.as_ref(),
-            );
-    }
-}
-
-impl FromUrlQueryPairs for MediaListParams {
-    fn from_url_query_pairs(query_pairs: UrlQueryPairsMap) -> Option<Self> {
-        Some(Self {
-            page: query_pairs.get(MediaListParamsField::Page),
-            per_page: query_pairs.get(MediaListParamsField::PerPage),
-            search: query_pairs.get(MediaListParamsField::Search),
-            after: query_pairs.get(MediaListParamsField::After),
-            modified_after: query_pairs.get(MediaListParamsField::ModifiedAfter),
-            author: query_pairs.get_csv(MediaListParamsField::Author),
-            author_exclude: query_pairs.get_csv(MediaListParamsField::AuthorExclude),
-            before: query_pairs.get(MediaListParamsField::Before),
-            modified_before: query_pairs.get(MediaListParamsField::ModifiedBefore),
-            exclude: query_pairs.get_csv(MediaListParamsField::Exclude),
-            include: query_pairs.get_csv(MediaListParamsField::Include),
-            offset: query_pairs.get(MediaListParamsField::Offset),
-            order: query_pairs.get(MediaListParamsField::Order),
-            orderby: query_pairs.get(MediaListParamsField::Orderby),
-            parent: query_pairs.get_csv(MediaListParamsField::Parent),
-            parent_exclude: query_pairs.get_csv(MediaListParamsField::ParentExclude),
-            search_columns: query_pairs.get_csv(MediaListParamsField::SearchColumns),
-            slug: query_pairs.get_csv(MediaListParamsField::Slug),
-            status: query_pairs.get_csv(MediaListParamsField::Status),
-            media_type: query_pairs.get(MediaListParamsField::MediaType),
-            mime_type: query_pairs.get(MediaListParamsField::MimeType),
-        })
-    }
-
-    fn supports_pagination() -> bool {
-        true
-    }
-}
-
 #[derive(Debug, Default, Serialize, uniffi::Record)]
 pub struct MediaUpdateParams {
     /// The date the post was published, in the site's timezone.
@@ -689,7 +616,7 @@ mod tests {
         let before = unit_test_example_date_as_query_value("before");
         let modified_before = unit_test_example_date_as_query_value("modified_before");
         format!(
-            "page=11&per_page=22&search=s_q&{after}&{modified_after}&author=111%2C112&author_exclude=211%2C212&{before}&{modified_before}&exclude=1111%2C1112&include=2111%2C2112&offset=11111&order=desc&orderby=slug&parent=44444%2C44445&search_columns=post_content%2Cpost_excerpt&slug=sl_1%2Csl_2&status=inherit%2Cprivate%2Ctrash&parent_exclude=55555%2C55556&media_type=image&mime_type=image%2Fjpeg"
+            "page=11&per_page=22&search=s_q&{after}&{modified_after}&author=111%2C112&author_exclude=211%2C212&{before}&{modified_before}&exclude=1111%2C1112&include=2111%2C2112&offset=11111&order=desc&orderby=slug&parent=44444%2C44445&parent_exclude=55555%2C55556&search_columns=post_content%2Cpost_excerpt&slug=sl_1%2Csl_2&status=inherit%2Cprivate%2Ctrash&media_type=image&mime_type=image%2Fjpeg"
         )
     }
 

wp_api/src/post_revisions.rs

@@ -40,6 +40,7 @@ pub enum WpApiParamPostRevisionsOrderBy {
 impl_as_query_value_from_to_string!(WpApiParamPostRevisionsOrderBy);
 
 #[derive(Debug, Default, PartialEq, Eq, uniffi::Record, WpDeriveParamsField)]
+#[supports_pagination(true)]
 pub struct PostRevisionListParams {
     /// Current page of the collection.
     /// Default: `1`
@@ -73,51 +74,6 @@ pub struct PostRevisionListParams {
     pub orderby: Option<WpApiParamPostRevisionsOrderBy>,
 }
 
-impl AppendUrlQueryPairs for PostRevisionListParams {
-    fn append_query_pairs(&self, query_pairs_mut: &mut QueryPairs) {
-        query_pairs_mut
-            .append_option_query_value_pair(PostRevisionListParamsField::Page, self.page.as_ref())
-            .append_option_query_value_pair(
-                PostRevisionListParamsField::PerPage,
-                self.per_page.as_ref(),
-            )
-            .append_option_query_value_pair(
-                PostRevisionListParamsField::Search,
-                self.search.as_ref(),
-            )
-            .append_vec_query_value_pair(PostRevisionListParamsField::Exclude, &self.exclude)
-            .append_vec_query_value_pair(PostRevisionListParamsField::Include, &self.include)
-            .append_option_query_value_pair(
-                PostRevisionListParamsField::Offset,
-                self.offset.as_ref(),
-            )
-            .append_option_query_value_pair(PostRevisionListParamsField::Order, self.order.as_ref())
-            .append_option_query_value_pair(
-                PostRevisionListParamsField::Orderby,
-                self.orderby.as_ref(),
-            );
-    }
-}
-
-impl FromUrlQueryPairs for PostRevisionListParams {
-    fn from_url_query_pairs(query_pairs: UrlQueryPairsMap) -> Option<Self> {
-        Some(Self {
-            page: query_pairs.get(PostRevisionListParamsField::Page),
-            per_page: query_pairs.get(PostRevisionListParamsField::PerPage),
-            search: query_pairs.get(PostRevisionListParamsField::Search),
-            exclude: query_pairs.get_csv(PostRevisionListParamsField::Exclude),
-            include: query_pairs.get_csv(PostRevisionListParamsField::Include),
-            offset: query_pairs.get(PostRevisionListParamsField::Offset),
-            order: query_pairs.get(PostRevisionListParamsField::Order),
-            orderby: query_pairs.get(PostRevisionListParamsField::Orderby),
-        })
-    }
-
-    fn supports_pagination() -> bool {
-        true
-    }
-}
-
 #[derive(Debug, Serialize, Deserialize, uniffi::Record, WpContextual)]
 pub struct SparsePostRevision {
     #[WpContext(edit, embed, view)]