Update Rust to 1.86.0 (#701)

Author: oguzkocer

Makefile

@@ -4,7 +4,7 @@
 docker_container_repo_dir=/app
 
 # Common docker options
-rust_docker_container := public.ecr.aws/docker/library/rust:1.85.1
+rust_docker_container := public.ecr.aws/docker/library/rust:1.86.0
 
 docker_opts_shared := --rm -v "$(PWD)":$(docker_container_repo_dir) -w $(docker_container_repo_dir)
 rust_docker_run := docker run -v $(PWD):/$(docker_container_repo_dir) -w $(docker_container_repo_dir) -it -e TEST_ALL_PLUGINS -e CARGO_HOME=/app/.cargo $(rust_docker_container)

wp_api/src/api_error.rs

@@ -571,7 +571,7 @@ impl WpSupportsLocalization for RequestExecutionErrorReason {
             RequestExecutionErrorReason::MisconfiguredHttpAuthenticationError { .. } => {
                 WpMessages::misconfigured_http_authentication_error()
             }
-            RequestExecutionErrorReason::MisconfiguredRateLimitError { .. } => {
+            RequestExecutionErrorReason::MisconfiguredRateLimitError => {
                 WpMessages::misconfigured_rate_limit_error()
             }
             RequestExecutionErrorReason::HttpForbiddenError { hostname } => {

wp_api/src/middleware.rs

@@ -442,7 +442,7 @@ mod tests {
                 Err(RequestExecutionError::RequestExecutionFailed {
                     status_code: Some(429),
                     redirects: None,
-                    reason: RequestExecutionErrorReason::MisconfiguredRateLimitError {},
+                    reason: RequestExecutionErrorReason::MisconfiguredRateLimitError,
                 })
             ));
         }

wp_api/src/parsed_url.rs

@@ -58,8 +58,8 @@ impl UrlExtension for Url {
         I::Item: AsRef<str>,
     {
         // Drop the trailing slash, so that `foo/` and `bar` turn into `foo/bar` instead of `foo//bar`.
-        if let Some(segments) = self.path_segments() {
-            if segments.last() == Some("") {
+        if let Some(mut segments) = self.path_segments() {
+            if segments.next_back() == Some("") {
                 self.path_segments_mut()?.pop();
             }
         }