Store: Remove simple createReducer usage (#36745)

* Remove createReducer from local-pickup

* Remove createReducer from flat-rate

* Remove createReducer from shipping-classes

* Remove createReducer from free-shipping

* Wrap with withoutPersistence

Author: sirreal

client/extensions/woocommerce/state/sites/shipping-classes/reducers.js

@@ -1,23 +1,19 @@
-/** @format */
-
 /**
  * Internal dependencies
  */
-import { createReducer } from 'state/utils';
+import { withoutPersistence } from 'state/utils';
 import {
 	WOOCOMMERCE_SHIPPING_CLASSES_REQUEST,
 	WOOCOMMERCE_SHIPPING_CLASSES_REQUEST_SUCCESS,
 } from 'woocommerce/state/action-types';
 import { LOADING } from 'woocommerce/state/constants';
 
-const reducers = {};
-
-reducers[ WOOCOMMERCE_SHIPPING_CLASSES_REQUEST ] = () => {
-	return LOADING;
-};
-
-reducers[ WOOCOMMERCE_SHIPPING_CLASSES_REQUEST_SUCCESS ] = ( state, { data } ) => {
-	return data;
-};
-
-export default createReducer( {}, reducers );
+export default withoutPersistence( function( state = {}, action ) {
+	switch ( action.type ) {
+		case WOOCOMMERCE_SHIPPING_CLASSES_REQUEST:
+			return LOADING;
+		case WOOCOMMERCE_SHIPPING_CLASSES_REQUEST_SUCCESS:
+			return action.data;
+	}
+	return state;
+} );

client/extensions/woocommerce/state/ui/shipping/zones/methods/flat-rate/reducer.js

@@ -1,10 +1,7 @@
-/** @format */
-
 /**
  * Internal dependencies
  */
-
-import { createReducer } from 'state/utils';
+import { withoutPersistence } from 'state/utils';
 import {
 	WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_TAXABLE,
 	WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_COST,
@@ -15,20 +12,20 @@ const initialState = {
 	cost: 5,
 };
 
-const reducer = {};
+export default withoutPersistence( function( state = initialState, action ) {
+	switch ( action.type ) {
+		case WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_TAXABLE:
+			return {
+				...state,
+				tax_status: action.isTaxable ? 'taxable' : 'none',
+			};
 
-reducer[ WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_TAXABLE ] = ( state, { isTaxable } ) => {
-	return {
-		...state,
-		tax_status: isTaxable ? 'taxable' : 'none',
-	};
-};
-
-reducer[ WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_COST ] = ( state, { cost } ) => {
-	return {
-		...state,
-		cost,
-	};
-};
+		case WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_COST:
+			return {
+				...state,
+				cost: action.cost,
+			};
+	}
 
-export default createReducer( initialState, reducer );
+	return state;
+} );

client/extensions/woocommerce/state/ui/shipping/zones/methods/free-shipping/reducer.js

@@ -1,10 +1,7 @@
-/** @format */
-
 /**
  * Internal dependencies
  */
-
-import { createReducer } from 'state/utils';
+import { withoutPersistence } from 'state/utils';
 import {
 	WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_CONDITION,
 	WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_MIN_COST,
@@ -15,20 +12,19 @@ const initialState = {
 	min_amount: 0,
 };
 
-const reducer = {};
-
-reducer[ WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_CONDITION ] = ( state, { condition } ) => {
-	return {
-		...state,
-		requires: condition,
-	};
-};
-
-reducer[ WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_MIN_COST ] = ( state, { cost } ) => {
-	return {
-		...state,
-		min_amount: cost,
-	};
-};
+export default withoutPersistence( function( state = initialState, action ) {
+	switch ( action.type ) {
+		case WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_CONDITION:
+			return {
+				...state,
+				requires: action.condition,
+			};
 
-export default createReducer( initialState, reducer );
+		case WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_MIN_COST:
+			return {
+				...state,
+				min_amount: action.cost,
+			};
+	}
+	return state;
+} );

client/extensions/woocommerce/state/ui/shipping/zones/methods/local-pickup/reducer.js

@@ -1,10 +1,7 @@
-/** @format */
-
 /**
  * Internal dependencies
  */
-
-import { createReducer } from 'state/utils';
+import { withoutPersistence } from 'state/utils';
 import {
 	WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_TAXABLE,
 	WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_COST,
@@ -15,20 +12,19 @@ const initialState = {
 	cost: 0,
 };
 
-const reducer = {};
-
-reducer[ WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_TAXABLE ] = ( state, { isTaxable } ) => {
-	return {
-		...state,
-		tax_status: isTaxable ? 'taxable' : 'none',
-	};
-};
-
-reducer[ WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_COST ] = ( state, { cost } ) => {
-	return {
-		...state,
-		cost,
-	};
-};
+export default withoutPersistence( function( state = initialState, action ) {
+	switch ( action.type ) {
+		case WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_TAXABLE:
+			return {
+				...state,
+				tax_status: action.isTaxable ? 'taxable' : 'none',
+			};
 
-export default createReducer( initialState, reducer );
+		case WOOCOMMERCE_SHIPPING_ZONE_METHOD_SET_COST:
+			return {
+				...state,
+				cost: action.cost,
+			};
+	}
+	return state;
+} );