Commit c7de1d9
phpcs: Fix and enable
Mostly this is the result of running phpcbf on files failing the sniff.
Things needing manual cleanup were:
* `projects/packages/image-cdn/tests/php/Image_CDN_Test.php`:
Remove a broken `@covers` that had no space between the tag and class
name.
* `projects/plugins/jetpack/tests/php/core-api/WPCOM_REST_API_V2_Field_Controller_Test.php`:
Fix a `@group` that was accidentally
"rest-api\n\nphpcs:disable Generic.Files.OneObjectStructurePerFile.MultipleFound".
* `projects/plugins/jetpack/tests/php/core-api/wpcom-fields/WPCOM_REST_API_V2_Attachment_VideoPress_Data_Test.php`:
* `projects/plugins/jetpack/tests/php/sync/Jetpack_Sync_Queue_TestBase.php`:
Move some `@group`s from the file comment to class comment.
* `projects/plugins/jetpack/tests/php/Functions_OpenGraph_Test.php`:
* `projects/plugins/jetpack/tests/php/general/Jetpack_Client_Server_Test.php`:
Fix where it got confused about whether a comment was a file or class
comment.
* `projects/plugins/jetpack/tests/php/json-api/Jetpack_Json_Api_Plugins_Endpoints_Test.php`:
Fix `@covers` for nonexistent class.
* `projects/plugins/jetpack/tests/php/modules/shortcodes/trait.http-request-cache.php`:
* `projects/plugins/jetpack/tests/php/trait-woo-tests.php`:
Manually fix, since the sniff doesn't recognize the trait as a test
class.
* Disable `PHPCompatibility.Attributes.NewAttributes.PHPUnitAttributeFound` in phpcompatibility-dev run.
`PHPCompatibility.Attributes.NewAttributes.Found` was already disabled.
Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/14603283610
Upstream-Ref: Automattic/jetpack@c49fe68Jetpack.PHPUnit.Attributes sniff (#43175)1 parent 4d31324 commit c7de1d9
File tree
6 files changed
+23
-18
lines changed- vendor
- automattic/jetpack-device-detection
- composer
6 files changed
+23
-18
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
8 | 12 | | |
9 | 13 | | |
10 | 14 | | |
| |||
232 | 236 | | |
233 | 237 | | |
234 | 238 | | |
| 239 | + | |
235 | 240 | | |
236 | 241 | | |
237 | 242 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | | - | |
| 5 | + | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
0 commit comments