Add boundary check to HarfBuzzTextShaper#20716
Merged
MrJul merged 2 commits intoAvaloniaUI:masterfrom Feb 20, 2026
Merged
Conversation
Contributor
|
Let's cover this with a unit test. We might be able to return earlier, so we do not create an HfBuffer. |
|
You can test this PR using the following package version. |
Contributor
Author
|
woops turns out it's prettt hard to mock a glyph typeface :( |
Contributor
|
The point is, you do not need to mock a GlyphTypeface. Our headless tests use actual font files. |
|
You can test this PR using the following package version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Add a basic boundary check, so empty string won't trigger index out of boundary exception.
What is the current behavior?
Shaping an empty text will throw execption
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Currently there seems no unit test associated with text shapers. please let me know if you need any.