Merge pull request #639 from AvaloniaUI/fixes/webview-tweaks

Accelerate WebView tweaks

Author: maxkatz6

accelerate/components/webview/nativewebdialog.md

@@ -224,7 +224,7 @@ var dialog = new NativeWebDialog
 
 // Create TaskCompletionSource so we can wait until window is closed.
 var tcs = new TaskCompletionSource();
-dialog.Closing += (s, e) => tcs.SetCompleted();
+dialog.Closing += (s, e) => tcs.SetResult();
 
 // Show the dialog
 dialog.Show(mainWindow);

accelerate/components/webview/quickstart.md

@@ -90,11 +90,10 @@ For multi-project solutions, you can store your license key in an [environment v
 
 ```xml
 <Window xmlns="https://github.com/avaloniaui"
-        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
-        xmlns:webview="using:Avalonia.Controls.WebView">
+        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml">
 
-    <webview:NativeWebView Source="https://avaloniaui.net/"
-                           NavigationCompleted="WebView_NavigationCompleted" />
+    <NativeWebView Source="https://avaloniaui.net/"
+                   NavigationCompleted="WebView_NavigationCompleted" />
 </Window>
 ```
 
@@ -132,7 +131,7 @@ dialog.Show();
 ### Using WebAuthenticationBroker
 
 ```csharp
-var authOptions = new WebAuthenticationOptions(
+var authOptions = new WebAuthenticatorOptions(
     RequestUri: new Uri("https://accounts.google.com/o/oauth2/auth?response_type=code&client_id=YOUR_CLIENT_ID&redirect_uri=http://localhost&scope=openid"),
     RedirectUri: new Uri("http://localhost")
 );
@@ -146,6 +145,8 @@ if (result.CallbackUri != null)
 }
 ```
 
+Replace `YOUR_CLIENT_ID` with the client ID for your application.
+
 ## Platform Prerequisites
 
 The WebView component relies on native web rendering implementations that must be available on the user's machine:

accelerate/components/webview/webauthenticationbroker.md

@@ -73,9 +73,9 @@ googleAuthRequestUri += "&redirect_uri=" + googleAuthRedirectUri;
 
 var result = await WebAuthenticationBroker.AuthenticateAsync(
     mainWindow,
-    new WebAuthenticationOptions(
-        RequestUri: new Uri(googleAuthRequestUri)
-        RedirectUri: new Uri(googleAuthRedirectUri));
+    new WebAuthenticatorOptions(
+        RequestUri: new Uri(googleAuthRequestUri),
+        RedirectUri: new Uri(googleAuthRedirectUri)));
 ```
 
 Similarly it can be done with [Microsoft identity](https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-auth-code-flow), [Facebook Login](https://developers.facebook.com/docs/facebook-login/) or other OAuth2 standard compatible options.
@@ -87,6 +87,6 @@ Similarly it can be done with [Microsoft identity](https://learn.microsoft.com/e
 | Platform Implementation  | ✖       | ✔*     | ✖     | ✔*   | ✔**         | ✔***         |
 | NativeWebDialog         | ✔       | ✔     | ✔     | ✖   | ✖         | ✖         |
 
-\* Apple platforms use ASWebAuthenticationSession implementation.
-\** Android uses CustomTabsIntent implementation, but support is experimental and might be changed.
-\*** Browser solution requires CORS to be configured to allow access to the redirected page.
+\* Apple platforms use ASWebAuthenticationSession implementation.  
+\** Android uses CustomTabsIntent implementation, but support is experimental and might be changed.  
+\*** Browser solution requires CORS to be configured to allow access to the redirected page.