Merge pull request #277 from Avanade/feat/newcartridges

lucianareginalino · web-flow · commit 3e9576d1ad51 · 2025-05-14T10:41:01.000-03:00
test: fix Mongo Repository Unit tests.
diff --git a/src/Liquid.Repository.Mongo/Exceptions/MongoException.cs b/src/Liquid.Repository.Mongo/Exceptions/MongoException.cs
@@ -8,7 +8,6 @@ namespace Liquid.Repository.Mongo.Exceptions
     /// Occurs when an exception has occurred in Mongo Db.
     /// </summary>
     /// <seealso cref="LiquidException" />
-    [Serializable]
     [ExcludeFromCodeCoverage]
     public class MongoException : LiquidException
     {
diff --git a/src/Liquid.Repository.Mongo/MongoClientFactory.cs b/src/Liquid.Repository.Mongo/MongoClientFactory.cs
@@ -20,7 +20,7 @@ public class MongoClientFactory : IMongoClientFactory
         public MongoClientFactory(IOptions<MongoDbSettings> settings)
         {
             _mongoClients = new Dictionary<string, IMongoClient>();
-            _settings = settings;
+            _settings = settings ?? throw new ArgumentNullException(nameof(settings));
         }
 
         ///<inheritdoc/>
diff --git a/test/Liquid.Repository.Mongo.Tests/IServiceCollectionExtensionsTests.cs b/test/Liquid.Repository.Mongo.Tests/IServiceCollectionExtensionsTests.cs
@@ -29,7 +29,7 @@ public IServiceCollectionExtensionsTests()
             var options = new MongoRunnerOptions
             {
                 UseSingleNodeReplicaSet = false,
-                AdditionalArguments = "--quiet"
+                AdditionalArguments = "--quiet",                
             };
 
             _runner = MongoRunner.Run(options);
@@ -43,7 +43,7 @@ public IServiceCollectionExtensionsTests()
             {
                 {"MyMongoEntityOptions:Settings:1:DatabaseName", _databaseName},
                 {"MyMongoEntityOptions:Settings:1:ConnectionString", _runner.ConnectionString},
-                {"MyMongoEntityOptions:Settings:1:CollectionName", "TestEntity"},
+                {"MyMongoEntityOptions:Settings:1:CollectionName", "ATestEntity"},
                 {"MyMongoEntityOptions:Settings:1:ShardKey", "id"},
                 {"MyMongoEntityOptions:Settings:2:DatabaseName", _databaseName},
                 {"MyMongoEntityOptions:Settings:2:ConnectionString", _runner.ConnectionString},
@@ -60,7 +60,7 @@ public IServiceCollectionExtensionsTests()
         [Fact]
         public void AddLiquidMongoRepository_WhenAdded_ServicesIsFilledForTestEntity()
         {
-            _services.AddLiquidMongoRepository<TestEntity, int>("MyMongoEntityOptions","TestEntity");
+            _services.AddLiquidMongoRepository<TestEntity, int>("MyMongoEntityOptions","ATestEntity");
             _services.AddLiquidMongoRepository<AnotherTestEntity, int>("MyMongoEntityOptions", "AnotherTestEntity");
             _serviceProvider = _services.BuildServiceProvider();
             Assert.NotNull(_serviceProvider.GetService<IMongoDataContext<TestEntity>>());
diff --git a/test/Liquid.Repository.Mongo.Tests/Liquid.Repository.Mongo.Tests.csproj b/test/Liquid.Repository.Mongo.Tests/Liquid.Repository.Mongo.Tests.csproj
@@ -17,9 +17,9 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
 	<PackageReference Include="EphemeralMongo.Core" Version="2.0.0" />
-	<PackageReference Include="EphemeralMongo6.runtime.linux-x64" Version="1.1.0" Condition="$([MSBuild]::IsOSPlatform('Linux'))" />
-	<PackageReference Include="EphemeralMongo6.runtime.osx-x64" Version="1.1.0" Condition="$([MSBuild]::IsOSPlatform('OSX'))" />
-	<PackageReference Include="EphemeralMongo6.runtime.win-x64" Version="2.0.0" Condition="$([MSBuild]::IsOSPlatform('Windows'))" />
+	<PackageReference Include="EphemeralMongo8.runtime.linux-x64" Version="2.0.0" Condition="$([MSBuild]::IsOSPlatform('Linux'))" />
+	<PackageReference Include="EphemeralMongo8.runtime.osx-x64" Version="2.0.0" Condition="$([MSBuild]::IsOSPlatform('OSX'))" />
+	<PackageReference Include="EphemeralMongo8.runtime.win-x64" Version="2.0.0" Condition="$([MSBuild]::IsOSPlatform('Windows'))" />
 	<PackageReference Include="Microsoft.Extensions.Configuration" Version="9.0.4" />
 	<PackageReference Include="NSubstitute" Version="5.3.0" />
 	  <PackageReference Include="xunit" Version="2.9.3" />
diff --git a/test/Liquid.Repository.Mongo.Tests/MongoClientFactoryTests.cs b/test/Liquid.Repository.Mongo.Tests/MongoClientFactoryTests.cs
@@ -21,7 +21,7 @@ public MongoClientFactoryTests()
             var options = new MongoRunnerOptions
             {
                 UseSingleNodeReplicaSet = false,
-                AdditionalArguments = "--quiet"
+                AdditionalArguments = "--quiet",
             };
 
             _runner = MongoRunner.Run(options);
@@ -44,7 +44,7 @@ public MongoClientFactoryTests()
                     {
                         CollectionName = "TestEntities2",
                         ShardKey = "id",
-                        ConnectionString = "incorrect connection string",
+                        ConnectionString = "",
                         DatabaseName = $"{_databaseName}-2"
                     }
                 }
@@ -78,5 +78,11 @@ public void GetClient_WhenDatabaseSettingsIsWrong_ThrowException()
             MongoEntitySettings settings = null;
             Assert.Throws<MongoDB.Driver.MongoConfigurationException>(() => _sut.GetClient("TestEntities2", out settings));
         }
+
+        [Fact]
+        public void Constructor_WhenSettingsIsNull_ThrowException()
+        {
+            Assert.Throws<ArgumentNullException>(() => new MongoClientFactory(null));
+        }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ namespace Liquid.Repository.Mongo.Exceptions`
`8`	`8`	`/// Occurs when an exception has occurred in Mongo Db.`
`9`	`9`	`/// </summary>`
`10`	`10`	`/// <seealso cref="LiquidException" />`
`11`		`- [Serializable]`
`12`	`11`	`[ExcludeFromCodeCoverage]`
`13`	`12`	`public class MongoException : LiquidException`
`14`	`13`	`{`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public class MongoClientFactory : IMongoClientFactory`
`20`	`20`	`public MongoClientFactory(IOptions<MongoDbSettings> settings)`
`21`	`21`	`{`
`22`	`22`	`_mongoClients = new Dictionary<string, IMongoClient>();`
`23`		`- _settings = settings;`
	`23`	`+ _settings = settings ?? throw new ArgumentNullException(nameof(settings));`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`///<inheritdoc/>`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public MongoClientFactoryTests()`
`21`	`21`	`var options = new MongoRunnerOptions`
`22`	`22`	`{`
`23`	`23`	`UseSingleNodeReplicaSet = false,`
`24`		`- AdditionalArguments = "--quiet"`
	`24`	`+ AdditionalArguments = "--quiet",`
`25`	`25`	`};`
`26`	`26`
`27`	`27`	`_runner = MongoRunner.Run(options);`
`@@ -44,7 +44,7 @@ public MongoClientFactoryTests()`
`44`	`44`	`{`
`45`	`45`	`CollectionName = "TestEntities2",`
`46`	`46`	`ShardKey = "id",`
`47`		`- ConnectionString = "incorrect connection string",`
	`47`	`+ ConnectionString = "",`
`48`	`48`	`DatabaseName = $"{_databaseName}-2"`
`49`	`49`	`}`
`50`	`50`	`}`
`@@ -78,5 +78,11 @@ public void GetClient_WhenDatabaseSettingsIsWrong_ThrowException()`
`78`	`78`	`MongoEntitySettings settings = null;`
`79`	`79`	`Assert.Throws<MongoDB.Driver.MongoConfigurationException>(() => _sut.GetClient("TestEntities2", out settings));`
`80`	`80`	`}`
	`81`	`+`
	`82`	`+ [Fact]`
	`83`	`+ public void Constructor_WhenSettingsIsNull_ThrowException()`
	`84`	`+ {`
	`85`	`+ Assert.Throws<ArgumentNullException>(() => new MongoClientFactory(null));`
	`86`	`+ }`
`81`	`87`	`}`
`82`	`88`	`}`