Skip to content

Commit 31ebbb0

Browse files
authored
Added logic for measure exception. Changed few strings
1 parent c6aba4b commit 31ebbb0

File tree

2 files changed

+25
-38
lines changed

2 files changed

+25
-38
lines changed

GwinstekLCRTester/MainWindow.xaml.cs

Lines changed: 24 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ namespace GwinstekLCRTester
1010
public partial class MainWindow : Window
1111
{
1212
private FileHandler fileHandler = new FileHandler();
13-
private RSCommunication rsConnector;
1413

1514
public MainWindow()
1615
{
@@ -166,30 +165,29 @@ private void ExecuteTests()
166165
frequencies[0] = Freq1.Text;
167166
}
168167

169-
if (rsConnector == null || !rsConnector._serialPort.IsOpen)
168+
RSCommunication rsConnector;
169+
try
170170
{
171-
try
172-
{
173-
rsConnector = new RSCommunication(
174-
portName: ComPorts.Text,
175-
baudRate: baudRate,
176-
parityNumber: (Parity)parity,
177-
dataBits: dataBits,
178-
stopBits: (StopBits)stopBits,
179-
handshakeType: (Handshake)handshake
180-
);
181-
}
182-
catch (ArgumentException)
183-
{
184-
System.Windows.MessageBox.Show("Nie można się połączyć z danym portem");
185-
return;
186-
}
187-
catch (FileNotFoundException)
188-
{
189-
System.Windows.MessageBox.Show("Nie można się połączyć z danym portem, jesteś pewien, że nie został w trakcie rozłączony?");
190-
return;
191-
}
171+
rsConnector = new RSCommunication(
172+
portName: ComPorts.Text,
173+
baudRate: baudRate,
174+
parityNumber: (Parity)parity,
175+
dataBits: dataBits,
176+
stopBits: (StopBits)stopBits,
177+
handshakeType: (Handshake)handshake
178+
);
179+
}
180+
catch (ArgumentException)
181+
{
182+
System.Windows.MessageBox.Show("Nie można się połączyć z danym portem");
183+
return;
192184
}
185+
catch (FileNotFoundException)
186+
{
187+
System.Windows.MessageBox.Show("Nie można się połączyć z danym portem, jesteś pewien, że nie został w trakcie rozłączony?");
188+
return;
189+
}
190+
193191
// zmienne pomocnicze
194192
int waitMs;
195193
bool continueMeas = true;
@@ -251,7 +249,6 @@ private void ExecuteTests()
251249
MessageBoxResult result = System.Windows.MessageBox.Show("Jeśli chcesz rozpocząć test seryjny kondensatora kilknij OK, jeśli nie wciśnij Cancel", "Czy kontynuować?", MessageBoxButton.OKCancel);
252250
if (result != MessageBoxResult.OK)
253251
{
254-
returnToIdle(rsConnector, false);
255252
continueMeas = false;
256253
break;
257254
}
@@ -319,7 +316,8 @@ private void ExecuteTests()
319316
return;
320317
}
321318
}
322-
319+
320+
returnToIdle(rsConnector, false);
323321
System.Windows.MessageBox.Show("Zakończono wszystkie testy");
324322
}
325323

@@ -389,13 +387,6 @@ private void Change_Mode(object sender, SelectionChangedEventArgs e)
389387
HzLabel4.Visibility = Visibility.Visible;
390388

391389
Freq1.IsReadOnly = false;
392-
Freq2.IsReadOnly = false;
393-
Freq3.IsReadOnly = false;
394-
Freq4.IsReadOnly = false;
395-
Freq1.Text = fileHandler.currentSettings.Freq1;
396-
Freq2.Text = fileHandler.currentSettings.Freq2;
397-
Freq3.Text = fileHandler.currentSettings.Freq3;
398-
Freq4.Text = fileHandler.currentSettings.Freq4;
399390
}
400391
}
401392

@@ -439,10 +430,6 @@ private void Window_Closing(object sender, System.ComponentModel.CancelEventArgs
439430
newSettings.CSVPath = FilePath.Text;
440431

441432
fileHandler.writeNewSettings(newSettings);
442-
if(rsConnector != null)
443-
{
444-
rsConnector.closePort();
445-
}
446433
}
447434
}
448-
}
435+
}

GwinstekLCRTester/RSCommunication.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ namespace GwinstekLCRTester
77
{
88
public class RSCommunication : IDisposable
99
{
10-
public SerialPort _serialPort;
10+
private static SerialPort _serialPort;
1111

1212
public static readonly string[] measurementTypes = {
1313

0 commit comments

Comments
 (0)