chore(assignment) Added some clarifications in assignments (#21)

Author: giorgosera

_includes/online-assignment/intro.md

@@ -3,6 +3,7 @@
 Hey there :)
 
 - Please read the instructions carefully before starting. 
+- Please make sure you read the deliverables section before submitting your assignment.
 - The instructions below include the expected time of finishing this assignment. If you spend significantly more time than expected then please check if your implementation does more things than the assignment asks for.
 - Please keep your solution as simple as possible! We are impressed by simple and elegant solutions.
 - If something is not clear to you please do not hesitate to get in touch with us for clarifications. We'd love to help you out!

back-end/code-review-exchange/assignment.md

@@ -14,7 +14,7 @@ Notes:
 An ad exchange is a platform which facilitates the buying and selling of ads in real time.
 
 - On one side of the ad exchange we have the mobile apps which send requests to our exchange to sell their traffic. 
-- On the other side, the exchange communicates with bidders which submit their bids for the traffic if they are interested in buying it.
+- On the other side, the exchange communicates with bidders which submit their bids for the traffic if they are interested in buying it. These bidders are 3rd party companies and the exchanges simply communicate with them via a predefined protocol.
 
 The ad exchange receives the bids and the highest bidder wins the auction and gets to show their ad. The flow is summarized in the diagram below.
 
@@ -32,6 +32,7 @@ Notes:
 
 - The requests to the bidders should be fired in parallel since the calls are independent and therefore we can avoid high latency.
 - If a bid request to a certain bidder fails then the exchange should dismiss that bid and continue its flow with the rest of the bidders.
+- The exchange should be able to facilitate an arbitrary number of bidder endpoints/connections in the future.
 
 # Tasks
 
@@ -63,9 +64,13 @@ Please feel free to suggest anything you think that can be improved. There is no
     - Go (Work in progress)
     - PHP (Work in progress) 
 2. When you accept the assignment a new repo will be created which is the one you will be working on. You have admin rights so you can do anything you want. This repo contains a branch called ```feat/ad-exchnage``` which contains the code that you will review.
-2. Click on the Pull Request tab and create a new Pull Request with base branch ```master``` and source branch ```feat/ad-exchange```. Use this Pull Request ONLY to add your code review comments.
+2. Click on the Pull Request tab and create a new Pull Request with base branch ```master``` and source branch ```feat/ad-exchange```. Use this Pull Request ONLY to add your code review comments. If you are not familiar with Github's pull requests please check out [this link](https://help.github.com/articles/creating-a-pull-request/) to find out more.
 3. Add your review comments in that Pull Request.
 
+### How do I submit my code review comments?
+
+Please use Github's code review tool to submit your code review comments. It's super easy to use but if you are not familiar with this tool please check out [this link](https://help.github.com/articles/reviewing-proposed-changes-in-a-pull-request/) to find out more.
+
 ## Task 2
 
 Implement your suggested improvements and end-to-end test cases to check that the business requirements are satisfied.
@@ -74,9 +79,15 @@ Implement your suggested improvements and end-to-end test cases to check that th
 - You are free to change whatever you want in the entire codebase. You can install any dependencies you might need. There is absolutely no limitation.
 - The codebase already contains some (failing) test code and fixtures. Again you can change whatever needs to be changed to make the tests run and verify that the app works as expected. Install anything you need. Change anything you need.   
 - For your end-to-end test cases you will need to know how to communicate with the bidders. The API documentation for this purpose can be found [here](https://bidderapi.docs.apiary.io).
-- Your new changes should be implemented in a separate Pull Request.
+- Your new changes should be implemented in a separate Pull Request. 
 - There is no need to implement unit tests, just the end to end tests!
 
+### Important note
+
+The bidder urls used in the original code do not work since this is a hypothetical scenario. However, you can assume that these are the valid urls we want to use in production. In your tests you should try to mock these endpoints as you would do in any case. 
+
+Please do not use the mock url which is auto-generated by the Apiary documentation. 
+
 # Deliverables
 
 At the end you should have TWO separate Pull Requests:

front-end/code-review-bidders/assignment.md

@@ -60,9 +60,13 @@ Please feel free to suggest anything you think that can be improved. There is no
     - [React](https://classroom.github.com/a/sQOFY9lb)
     - Angular (Work in progress)
 2. When you accept the assignment a new repo will be created which is the one you will be working on. You have admin rights so you can do anything you want. This repo contains a branch called ```feat/view-bidders``` which contains the code that you will review.
-2. Click on the Pull Request tab and create a new Pull Request with base branch ```master``` and source branch ```feat/view-bidders```. Use this Pull Request ONLY to add your code review comments.
+2. Click on the Pull Request tab and create a new Pull Request with base branch ```master``` and source branch ```feat/view-bidders```. Use this Pull Request ONLY to add your code review comments. If you are not familiar with Github's pull requests please check out [this link](https://help.github.com/articles/creating-a-pull-request/) to find out more.
 3. Add your review comments in that Pull Request.
 
+### How do I submit my code review comments?
+
+Please use Github's code review tool to submit your code review comments. It's super easy to use but if you are not familiar with this tool please check out [this link](https://help.github.com/articles/reviewing-proposed-changes-in-a-pull-request/) to find out more.
+
 ## Task 2
 
 Implement your suggested improvements and end-to-end test cases to check that the business requirements are satisfied.
@@ -74,6 +78,12 @@ Implement your suggested improvements and end-to-end test cases to check that th
 - Your new changes should be implemented in a separate Pull Request.
 - There is no need to implement unit tests, just the end to end tests!
 
+### Important note
+
+The Bidder Management API url used in the original code does not work since this is a hypothetical scenario. However, you can assume that this is the valid url we want to use in production. In your tests you should try to mock that endpoint as you would do in any case. 
+
+Please do not use the mock url which is auto-generated by the Apiary documentation. 
+
 ### Styleguide
 
 If you need to implement styling please use the CSS styling already implemented in {{site.companyName}}'s [styleguide]({{page.styleguideUrl}}).