You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: back-end/code-review-exchange/assignment.md
+7-4Lines changed: 7 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -50,7 +50,7 @@ The time estimates for the tasks above assume that you are familiar or have prof
50
50
51
51
Review the code carefully and add any feedback/comments/suggestions you may have.
52
52
53
-
Please feel free to suggest anything you think that can be improved. Let us know the reasoning behind your suggestions.
53
+
Please feel free to suggest anything you think that can be improved. There is no limitation on what you can suggest so add your comments freely. Please do not forget to explain your reasoning behind your suggestions.
54
54
55
55
### Where can I find the code to be reviewed?
56
56
@@ -61,20 +61,23 @@ Please feel free to suggest anything you think that can be improved. Let us know
61
61
- Go (Work in progress)
62
62
- PHP (Work in progress)
63
63
- Ruby (Work in progress)
64
-
2. When you accept the assignment a new repo will be created which is the one you will be working on. You have admin rights so you can do anything you want.
65
-
2. Click on the Pull Request tab and create a new Pull Request with base branch ```master``` and source branch ```feat/ad-exchange```.
64
+
2. When you accept the assignment a new repo will be created which is the one you will be working on. You have admin rights so you can do anything you want. This repo contains a branch called ```feat/ad-exchnage``` which contains the code that you will review.
65
+
2. Click on the Pull Request tab and create a new Pull Request with base branch ```master``` and source branch ```feat/ad-exchange```. Use this Pull Request ONLY to add your code review comments.
66
66
3. Add your review comments in that Pull Request.
67
67
68
68
## Task 2
69
69
70
-
Implement your suggested improvements and implement end-to-end test cases to check that the business requirements are satisfied.
70
+
Implement your suggested improvements and end-to-end test cases to check that the business requirements are satisfied.
71
71
72
72
- You are free to change whatever you want in the entire codebase. You can install any dependencies you might need. There is absolutely no limitation.
73
73
- The codebase already contains some (failing) test code and fixtures. Again you can change whatever needs to be changed to make the tests run and verify that the app works as expected. Install anything you need. Change anything you need.
74
74
- For your end-to-end test cases you will need to know how to communicate with the bidders. The API documentation for this purpose can be found [here](https://bidderapi.docs.apiary.io).
75
75
- Your new changes should be implemented in a separate Pull Request.
76
+
- There is no need to implement unit tests, just the end to end tests!
76
77
77
78
# Deliverables
78
79
80
+
At the end you should have TWO separate Pull Requests:
81
+
79
82
1. The original Pull Request which contains your review comments.
80
83
2. The new Pull Request that contains your changes. Feel free to add any interesting approaches or important points in the PR's description.
0 commit comments