Skip to content

Commit 24a3933

Browse files
authored
Merge pull request matrix-org#5416 from matrix-org/t3chguy/fix/14852
Fix poorly i18n'd string
2 parents b32a2c1 + 71e2536 commit 24a3933

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

src/components/views/settings/EventIndexPanel.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,13 @@ export default class EventIndexPanel extends React.Component {
129129
eventIndexingSettings = (
130130
<div>
131131
<div className='mx_SettingsTab_subsectionText'>
132-
{_t( "Securely cache encrypted messages locally for them " +
133-
"to appear in search results, using ")
134-
} {formatBytes(this.state.eventIndexSize, 0)}
135-
{_t( " to store messages from ")}
136-
{formatCountLong(this.state.roomCount)} {_t("rooms.")}
132+
{_t("Securely cache encrypted messages locally for them " +
133+
"to appear in search results, using %(size)s to store messages from %(count)s rooms.",
134+
{
135+
size: formatBytes(this.state.eventIndexSize, 0),
136+
count: formatCountLong(this.state.roomCount),
137+
},
138+
)}
137139
</div>
138140
<div>
139141
<AccessibleButton kind="primary" onClick={this._onManage}>

src/i18n/strings/en_EN.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -935,9 +935,8 @@
935935
"Failed to set display name": "Failed to set display name",
936936
"Encryption": "Encryption",
937937
"Individually verify each session used by a user to mark it as trusted, not trusting cross-signed devices.": "Individually verify each session used by a user to mark it as trusted, not trusting cross-signed devices.",
938-
"Securely cache encrypted messages locally for them to appear in search results, using ": "Securely cache encrypted messages locally for them to appear in search results, using ",
939-
" to store messages from ": " to store messages from ",
940-
"rooms.": "rooms.",
938+
"Securely cache encrypted messages locally for them to appear in search results, using %(size)s to store messages from %(count)s rooms.|other": "Securely cache encrypted messages locally for them to appear in search results, using %(size)s to store messages from %(count)s rooms.",
939+
"Securely cache encrypted messages locally for them to appear in search results, using %(size)s to store messages from %(count)s rooms.|one": "Securely cache encrypted messages locally for them to appear in search results, using %(size)s to store messages from %(count)s room.",
941940
"Manage": "Manage",
942941
"Securely cache encrypted messages locally for them to appear in search results.": "Securely cache encrypted messages locally for them to appear in search results.",
943942
"%(brand)s is missing some components required for securely caching encrypted messages locally. If you'd like to experiment with this feature, build a custom %(brand)s Desktop with <nativeLink>search components added</nativeLink>.": "%(brand)s is missing some components required for securely caching encrypted messages locally. If you'd like to experiment with this feature, build a custom %(brand)s Desktop with <nativeLink>search components added</nativeLink>.",

0 commit comments

Comments
 (0)