Look for Imgur client ID in Info.plist (#1204)

Author: nolanw

App/Extensions/ImgurAnonymousAPI+Shared.swift

@@ -10,11 +10,6 @@ import AwfulSettings
 import KeychainAccess
 import AuthenticationServices
 
-// App-specific Imgur constants
-private enum AppImgurConstants {
-    static let clientID = "99240c4154dd0b4"
-}
-
 // MARK: - Imgur Auth Manager
 
 private let authLogger = Logger(subsystem: Bundle.main.bundleIdentifier!, category: "ImgurAuthManager")
@@ -60,7 +55,10 @@ public final class ImgurAuthManager: NSObject, ImgurAuthProvider {
     // MARK: - ImgurAuthProvider Protocol
 
     public var clientID: String {
-        return AppImgurConstants.clientID
+        guard let clientID = Bundle.main.object(forInfoDictionaryKey: "ImgurClientId") as? String else {
+            fatalError("Missing Imgur client ID (is the IMGUR_CLIENT_ID build setting set, e.g. in Local.xcconfig?")
+        }
+        return clientID
     }
 
     public var isAuthenticated: Bool {

App/Resources/Info.plist

@@ -97,5 +97,7 @@
 	</array>
 	<key>UIViewControllerBasedStatusBarAppearance</key>
 	<true/>
+	<key>ImgurClientId</key>
+	<string>${IMGUR_CLIENT_ID}</string>
 </dict>
 </plist>

Awful.xcodeproj/project.pbxproj

@@ -340,6 +340,7 @@
 		1C16FC171CD1848400C88BD1 /* ComposeTextViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ComposeTextViewController.swift; sourceTree = "<group>"; };
 		1C16FC191CD42EB300C88BD1 /* PostPreviewViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = PostPreviewViewController.swift; sourceTree = "<group>"; };
 		1C1BF9C119AB9E6200E8FBBC /* InAppActionSheet.xib */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = file.xib; path = InAppActionSheet.xib; sourceTree = "<group>"; };
+		1C1CB8DB2D9A5D7800900BAA /* Local.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = Local.entitlements; sourceTree = SOURCE_ROOT; };
 		1C1E57502C2521580075E3B6 /* platinum-member-white.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "platinum-member-white.png"; sourceTree = "<group>"; };
 		1C1F0F0E2B8A8C9700F097D3 /* AwfulModelTypes */ = {isa = PBXFileReference; lastKnownFileType = text; path = AwfulModelTypes; sourceTree = SOURCE_ROOT; };
 		1C1F0F132B8B091600F097D3 /* AwfulTheming */ = {isa = PBXFileReference; lastKnownFileType = wrapper; path = AwfulTheming; sourceTree = "<group>"; };
@@ -652,6 +653,7 @@
 				1C15334E20708F140021A2BD /* Common-Debug.xcconfig */,
 				1C15334F20708F250021A2BD /* Common-Release.xcconfig */,
 				1C15334B20707EB10021A2BD /* Common.xcconfig */,
+				1C1CB8DB2D9A5D7800900BAA /* Local.entitlements */,
 				1C15335220709E950021A2BD /* Local.xcconfig */,
 			);
 			path = Config;

Local.sample.xcconfig

@@ -5,3 +5,6 @@
 
 // To get builds running on your device, uncomment this next line and paste in your Team ID from the Developer Portal.
 // DEVELOPMENT_TEAM = YOUR_TEAM_ID_HERE
+
+// For Imgur functionality, obtain an Imgur API client ID by making a new one at http://api.imgur.com/oauth2/addclientor or using an existing one from https://imgur.com/account/settings/apps then specify the ID here.
+// IMGUR_CLIENT_ID = YOUR_CLIENT_ID_HERE

README.md

@@ -24,7 +24,7 @@ This app is not endorsed by Something Awful.
 
 Please drop by [the thread][current thread] if you could use a hand with any of these steps!
 
-You need Xcode 15 to build and run Awful. You can [download Xcode for free from Apple](https://developer.apple.com/download/). Then:
+You need Xcode 16 to build and run Awful. You can [download Xcode for free from Apple](https://developer.apple.com/download/). Then:
 
 1. Clone the repository: `git clone --recursive https://github.com/Awful/Awful.app Awful-app`
 2. Open the Xcode project and build away: `xed Awful-app`