Crash when saving favorite smilies

[syncsynchalt]

Description

When long-pressing a smilie and clicking "Save :smilie: to favorites" my app crashes. The below line in Console.app implies it's trying to write to the bundled sqlite db. I've been trying to reproduce this in the debugger, but it only seems to happen for me in the live app. In AwfulDebug I don't get a crash and the functionality works.

This has happened for me for months. I've tried deleting and re-installing the app, no luck. I wouldn't mind solving this myself if anyone has a clue on how to reproduce or fix the state on my phone. I do get a similar crash in the debug app when SmilieAppContainer:AppGroupIdentifier isn't set to my custom app group id, but I assume entitlements in the live app are correct so this wouldn't be exactly it.

The crash log:

default	17:31:19.276227-0700	Awful	Awful/URLMenuPresenter.swift:483: Fatal error: 'try!' expression unexpectedly raised an error: Error Domain=NSCocoaErrorDomain Code=513 "The file couldn’t be saved because you don’t have permission." UserInfo={NSPersistentStoreOptions={
    NSReadOnlyPersistentStoreOption = 1;
}, reason=Unable to write to file opened Read Only., storeURL=/var/containers/Bundle/Application/5603862F-EB30-4A66-9119-52B509828036/Awful.app/Smilies_Smilies.bundle/Smilies.sqlite}

Repro steps

On my phone:

• open Awful.ipa
• go to Bookmarks
• pick a thread
• page around until I see a smilie
• long-press on smilie
• click "Add :smilie: to favorites"

What happens:

• app crash

What should happen:

• menu closes, app keeps running

More info

iphone 12 mini, running ios 18.1.1.

Awful.ipa console log from the above run attached.

smilies-crash-console.log

[syncsynchalt]

(needless to say this is low priority, I'm just putting in an issue when I got stuck figuring it out myself)

[syncsynchalt]

Oh I was wrong, it does look similar to the error path seen in AwfulDebug when entitlements aren't right, they both go down this route. Turns out I'm just bad at Console.app:

default	17:41:50.713804-0700	Awful	Requesting app group container lookup; personaid = 1000, type = DEFAULT, name = 1BBCC224-E3C1-45AD-8F04-3076D1C682EB, origin [pid = 0, personaid = 0], proximate [pid = 0, personaid = 0], identifier = <private>, euid = 501, uid = 501, platform = 2
error	17:41:50.715711-0700	Awful	container_create_or_lookup_app_group_path_by_app_group_identifier: client is not entitled
default	17:41:50.715744-0700	Awful	NSURL *AppContainerSmilieStoreURL(void) can't find container folder

[nolanw]

Well we could certainly do a better job handling that error at a minimum. I wonder if the read-only store got involved because it's the only store we managed to add successfully?

I don't have any explanation for why the live app would have permissisons problems on the shared container though. Will have to ponder. Appreciate the writeup!