Merge pull request #28 from Axelrod-Python/issue-18

Add validation of original name and test

Author: drvinceknight

src/axelrod_fortran/player.py

@@ -46,8 +46,10 @@ def original_name(self):
 
     @original_name.setter
     def original_name(self, value):
-        # TODO Validate the value against list of known fortran functions
-        self.__original_name = value
+        if value in characteristics:
+            self.__original_name = value
+        else:
+            raise ValueError(f'{value} is not a valid Fortran function')
 
     @property
     def original_function(self):

tests/test_player.py

@@ -6,6 +6,7 @@
 from ctypes import c_int, c_float, POINTER
 
 import itertools
+import pytest
 
 C, D = Action.C, Action.D
 
@@ -20,6 +21,8 @@ def test_init():
             POINTER(c_int), POINTER(c_int), POINTER(c_int), POINTER(c_int),
             POINTER(c_float))
         assert player.original_function.restype == c_int
+        with pytest.raises(ValueError):
+            player = Player('test')
 
 
 def test_matches():