Fixes a bug in validating legacy recordings (#499)

bjornvolcker · web-flow · commit 3feb546c0467 · 2025-05-16T12:25:59.000+02:00
Hashing algorithm is by definition known is therefore set when
creating a legacy object.

Version is bumped to v2.2.3

Co-authored-by: bjornvolcker &lt;bjornvolcker@users.noreply.github.com&gt;
diff --git a/lib/src/sv_auth.c b/lib/src/sv_auth.c
@@ -1489,6 +1489,8 @@ add_bitstream_unit(signed_video_t *self, const uint8_t *bu_data, size_t bu_data_
       self->legacy_sv = legacy_sv_create(self);
       SV_THROW_IF(!self->legacy_sv, SV_MEMORY);
       sv_accumulated_validation_init(self->accumulated_validation);
+      // Hash algorithm is by definition known.
+      validation_flags->hash_algo_known = true;
     }
     if (nalus_pending_registration && validation_flags->hash_algo_known) {
       SV_THROW(reregister_bu(self));
diff --git a/lib/src/sv_internal.h b/lib/src/sv_internal.h
@@ -50,7 +50,7 @@
 #define DEFAULT_HASH_SIZE (256 / 8)
 
 #define SV_VERSION_BYTES 3
-#define SIGNED_VIDEO_VERSION "v2.2.2"
+#define SIGNED_VIDEO_VERSION "v2.2.3"
 #define SV_VERSION_MAX_STRLEN 19  // Longest possible string including 'ONVIF' prefix
 
 #define DEFAULT_AUTHENTICITY_LEVEL SV_AUTHENTICITY_LEVEL_FRAME
diff --git a/meson.build b/meson.build
@@ -1,5 +1,5 @@
 project('signed-video-framework', 'c',
-  version : '2.2.2',
+  version : '2.2.3',
   meson_version : '>= 0.53.0',
   default_options : [ 'warning_level=2',
                       'werror=true',

Original file line number	Diff line number	Diff line change
`@@ -1489,6 +1489,8 @@ add_bitstream_unit(signed_video_t self, const uint8_t bu_data, size_t bu_data_`
`1489`	`1489`	`self->legacy_sv = legacy_sv_create(self);`
`1490`	`1490`	`SV_THROW_IF(!self->legacy_sv, SV_MEMORY);`
`1491`	`1491`	`sv_accumulated_validation_init(self->accumulated_validation);`
	`1492`	`+ // Hash algorithm is by definition known.`
	`1493`	`+ validation_flags->hash_algo_known = true;`
`1492`	`1494`	`}`
`1493`	`1495`	`if (nalus_pending_registration && validation_flags->hash_algo_known) {`
`1494`	`1496`	`SV_THROW(reregister_bu(self));`