Skip to content

Commit bd64713

Browse files
authored
Removes two unused member variables (#428)
1 parent 6810d57 commit bd64713

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

lib/src/sv_internal.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -298,11 +298,6 @@ struct _signed_video_t {
298298
// the first signing attempt, triggering SEI generation at the end
299299
// of GOP.
300300

301-
// TODO: Remove this flag when the deprecated API get_nalus_to_prepend have been removed.
302-
bool avoid_checking_available_seis; // Temporary flag to avoid checking for available SEIs when
303-
// peek Bitstream Units are used when getting SEIs, since
304-
// they might be postponed.
305-
306301
// For signing plugin
307302
void *plugin_handle;
308303
sign_or_verify_data_t *sign_data; // Pointer to all necessary information to sign in a plugin.
@@ -322,7 +317,6 @@ struct _signed_video_t {
322317
uint16_t last_two_bytes;
323318
sei_data_t sei_data_buffer[MAX_SEI_DATA_BUFFER];
324319
int sei_data_buffer_idx;
325-
int num_of_completed_seis;
326320

327321
// Members only used for validation
328322
// TODO: Collect everything needed by the authentication part only in one struct/object, which

lib/src/sv_sign.c

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -494,15 +494,6 @@ prepare_for_signing(signed_video_t *self)
494494
// Mark the start of signing when the first Bitstream Unit is passed in and a signing
495495
// key has been set.
496496
self->signing_started = true;
497-
// Check if we have BUs to prepend waiting to be pulled. If we have one item only, this is an
498-
// empty list item, the pull action has no impact. We can therefore silently remove it and
499-
// proceed. But if there are vital SEIs waiting to be pulled we return an error message
500-
// (SV_NOT_SUPPORTED).
501-
502-
if (!self->avoid_checking_available_seis) {
503-
SV_THROW_IF_WITH_MSG(
504-
self->num_of_completed_seis > 0, SV_NOT_SUPPORTED, "There are remaining SEIs.");
505-
}
506497
SV_CATCH()
507498
SV_DONE(status)
508499

@@ -732,9 +723,6 @@ signed_video_get_sei(signed_video_t *self,
732723
// Only display a SEI if the |peek_bu| is a primary picture Bitstream Unit.
733724
if (!((bu_info.bu_type == BU_TYPE_I || bu_info.bu_type == BU_TYPE_P) &&
734725
bu_info.is_primary_slice)) {
735-
// Flip the sanity check flag since there are pending SEIs, which could not be fetched without
736-
// breaking the H.26x standard.
737-
self->avoid_checking_available_seis = true;
738726
return SV_OK;
739727
}
740728
}

0 commit comments

Comments
 (0)