Skip to content

Commit 3a3eec1

Browse files
committed
Align auto-config tests with AF 4.6.0 changes
In AF 4.6.0, we've split the AxonServerAutoConfiguration class into two auto-config classes. As the test case excluded AxonServer by excluding the config class, the other (new) config class of 4.6.0 broke the tests.
1 parent 761951e commit 3a3eec1

File tree

1 file changed

+38
-50
lines changed

1 file changed

+38
-50
lines changed

springcloud-spring-boot-autoconfigure/src/test/java/org/axonframework/extensions/springcloud/autoconfig/SpringCloudAutoConfigurationTest.java

Lines changed: 38 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2010-2018. Axon Framework
2+
* Copyright (c) 2010-2022. Axon Framework
33
*
44
* Licensed under the Apache License, Version 2.0 (the "License");
55
* you may not use this file except in compliance with the License.
@@ -14,21 +14,6 @@
1414
* limitations under the License.
1515
*/
1616

17-
/*
18-
* Copyright (c) 2010-2018. Axon Framework
19-
* Licensed under the Apache License, Version 2.0 (the "License");
20-
* you may not use this file except in compliance with the License.
21-
* You may obtain a copy of the License at
22-
*
23-
* http://www.apache.org/licenses/LICENSE-2.0
24-
*
25-
* Unless required by applicable law or agreed to in writing, software
26-
* distributed under the License is distributed on an "AS IS" BASIS,
27-
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
28-
* See the License for the specific language governing permissions and
29-
* limitations under the License.
30-
*/
31-
3217
package org.axonframework.extensions.springcloud.autoconfig;
3318

3419
import org.axonframework.commandhandling.CommandBus;
@@ -38,15 +23,13 @@
3823
import org.axonframework.commandhandling.distributed.CommandRouter;
3924
import org.axonframework.commandhandling.distributed.DistributedCommandBus;
4025
import org.axonframework.commandhandling.distributed.RoutingStrategy;
41-
import org.axonframework.common.ReflectionUtils;
4226
import org.axonframework.extensions.springcloud.commandhandling.SpringCloudCommandRouter;
4327
import org.axonframework.extensions.springcloud.commandhandling.SpringHttpCommandBusConnector;
28+
import org.axonframework.extensions.springcloud.commandhandling.mode.AcceptAllCommandsDiscoveryMode;
4429
import org.axonframework.extensions.springcloud.commandhandling.mode.CapabilityDiscoveryMode;
4530
import org.axonframework.extensions.springcloud.commandhandling.mode.IgnoreListingDiscoveryMode;
4631
import org.axonframework.extensions.springcloud.commandhandling.mode.MemberCapabilitiesController;
4732
import org.axonframework.extensions.springcloud.commandhandling.mode.RestCapabilityDiscoveryMode;
48-
import org.axonframework.extensions.springcloud.commandhandling.mode.AcceptAllCommandsDiscoveryMode;
49-
import org.axonframework.springboot.autoconfig.AxonServerAutoConfiguration;
5033
import org.junit.jupiter.api.*;
5134
import org.junit.jupiter.api.extension.*;
5235
import org.springframework.boot.autoconfigure.AutoConfigurations;
@@ -85,29 +68,30 @@ class SpringCloudAutoConfigurationTest {
8568
.withConfiguration(AutoConfigurations.of(Context.class));
8669

8770
@Test
88-
void testDefaultSpringCloudAutoConfiguration() {
89-
contextRunner.run(context -> {
90-
assertThat(context).getBeanNames(RoutingStrategy.class)
91-
.isEmpty();
92-
assertThat(context).getBeanNames(RestTemplate.class)
93-
.isEmpty();
94-
assertThat(context).getBeanNames(CapabilityDiscoveryMode.class)
95-
.isEmpty();
96-
assertThat(context).getBeanNames(CommandRouter.class)
97-
.isEmpty();
98-
assertThat(context).getBeanNames(CommandBusConnector.class)
99-
.isEmpty();
71+
void defaultSpringCloudAutoConfiguration() {
72+
contextRunner.withPropertyValues("axon.axonserver.enabled=false")
73+
.run(context -> {
74+
assertThat(context).getBeanNames(RoutingStrategy.class)
75+
.isEmpty();
76+
assertThat(context).getBeanNames(RestTemplate.class)
77+
.isEmpty();
78+
assertThat(context).getBeanNames(CapabilityDiscoveryMode.class)
79+
.isEmpty();
80+
assertThat(context).getBeanNames(CommandRouter.class)
81+
.isEmpty();
82+
assertThat(context).getBeanNames(CommandBusConnector.class)
83+
.isEmpty();
10084

101-
assertThat(context).getBeanNames(CommandBus.class)
102-
.hasSize(1);
103-
assertThat(context).getBean(CommandBus.class)
104-
.isExactlyInstanceOf(SimpleCommandBus.class);
105-
});
85+
assertThat(context).getBeanNames(CommandBus.class)
86+
.hasSize(1);
87+
assertThat(context).getBean(CommandBus.class)
88+
.isExactlyInstanceOf(SimpleCommandBus.class);
89+
});
10690
}
10791

10892
@Test
109-
void testEnabledSpringCloudAutoConfiguration() {
110-
contextRunner.withPropertyValues("axon.distributed.enabled=true")
93+
void enabledSpringCloudAutoConfiguration() {
94+
contextRunner.withPropertyValues("axon.distributed.enabled=true", "axon.axonserver.enabled=false")
11195
.run(context -> {
11296
assertThat(context).getBeanNames(RoutingStrategy.class)
11397
.hasSize(1);
@@ -156,10 +140,11 @@ void testEnabledSpringCloudAutoConfiguration() {
156140
}
157141

158142
@Test
159-
void testDisablingIgnoreListingOnlyCreatesRestCapabilityDiscoveryMode() {
143+
void disablingIgnoreListingOnlyCreatesRestCapabilityDiscoveryMode() {
160144
contextRunner.withPropertyValues(
161145
"axon.distributed.enabled=true",
162-
"axon.distributed.spring-cloud.enable-ignore-listing=false"
146+
"axon.distributed.spring-cloud.enable-ignore-listing=false",
147+
"axon.axonserver.enabled=false"
163148
).run(context -> {
164149
assertThat(context).getBeanNames(CapabilityDiscoveryMode.class)
165150
.hasSize(1);
@@ -169,11 +154,12 @@ void testDisablingIgnoreListingOnlyCreatesRestCapabilityDiscoveryMode() {
169154
}
170155

171156
@Test
172-
void testDisablingIgnoreListingAndAcceptAllOnlyCreatesRestCapabilityDiscoveryMode() {
157+
void disablingIgnoreListingAndAcceptAllOnlyCreatesRestCapabilityDiscoveryMode() {
173158
contextRunner.withPropertyValues(
174159
"axon.distributed.enabled=true",
175160
"axon.distributed.spring-cloud.enable-ignore-listing=false",
176-
"axon.distributed.spring-cloud.enable-accept-all-commands=false"
161+
"axon.distributed.spring-cloud.enable-accept-all-commands=false",
162+
"axon.axonserver.enabled=false"
177163
).run(context -> {
178164
assertThat(context).getBeanNames(CapabilityDiscoveryMode.class)
179165
.hasSize(1);
@@ -183,11 +169,12 @@ void testDisablingIgnoreListingAndAcceptAllOnlyCreatesRestCapabilityDiscoveryMod
183169
}
184170

185171
@Test
186-
void testEnablingIgnoreListingCreatesTwoCapabilityDiscoveryModeInstances() {
172+
void enablingIgnoreListingCreatesTwoCapabilityDiscoveryModeInstances() {
187173
contextRunner.withPropertyValues(
188174
"axon.distributed.enabled=true",
189175
"axon.distributed.spring-cloud.enable-ignore-listing=true",
190-
"axon.distributed.spring-cloud.enable-accept-all-commands=false"
176+
"axon.distributed.spring-cloud.enable-accept-all-commands=false",
177+
"axon.axonserver.enabled=false"
191178
).run(context -> {
192179
assertThat(context).getBeanNames(CapabilityDiscoveryMode.class)
193180
.hasSize(2);
@@ -199,11 +186,12 @@ void testEnablingIgnoreListingCreatesTwoCapabilityDiscoveryModeInstances() {
199186
}
200187

201188
@Test
202-
void testEnablingAcceptAllCreatesTwoCapabilityDiscoveryModeInstances() {
189+
void enablingAcceptAllCreatesTwoCapabilityDiscoveryModeInstances() {
203190
contextRunner.withPropertyValues(
204191
"axon.distributed.enabled=true",
205192
"axon.distributed.spring-cloud.enable-ignore-listing=false",
206-
"axon.distributed.spring-cloud.enable-accept-all-commands=true"
193+
"axon.distributed.spring-cloud.enable-accept-all-commands=true",
194+
"axon.axonserver.enabled=false"
207195
).run(context -> {
208196
assertThat(context).getBeanNames(CapabilityDiscoveryMode.class)
209197
.hasSize(2);
@@ -215,11 +203,12 @@ void testEnablingAcceptAllCreatesTwoCapabilityDiscoveryModeInstances() {
215203
}
216204

217205
@Test
218-
void testEnablingIgnoreListingAndAcceptAllCreatesTwoCapabilityDiscoveryModeInstances() {
206+
void enablingIgnoreListingAndAcceptAllCreatesTwoCapabilityDiscoveryModeInstances() {
219207
contextRunner.withPropertyValues(
220208
"axon.distributed.enabled=true",
221209
"axon.distributed.spring-cloud.enable-ignore-listing=True",
222-
"axon.distributed.spring-cloud.enable-accept-all-commands=true"
210+
"axon.distributed.spring-cloud.enable-accept-all-commands=true",
211+
"axon.axonserver.enabled=false"
223212
).run(context -> {
224213
assertThat(context).getBeanNames(CapabilityDiscoveryMode.class)
225214
.hasSize(2);
@@ -242,8 +231,7 @@ void testEnablingIgnoreListingAndAcceptAllCreatesTwoCapabilityDiscoveryModeInsta
242231
JmxAutoConfiguration.class,
243232
WebClientAutoConfiguration.class,
244233
HibernateJpaAutoConfiguration.class,
245-
DataSourceAutoConfiguration.class,
246-
AxonServerAutoConfiguration.class
234+
DataSourceAutoConfiguration.class
247235
})
248236
public static class Context {
249237

0 commit comments

Comments
 (0)