Skip to content

Commit f3be72d

Browse files
committed
Align test dependencies and enforce JUnit5
Align test dependencies and enforce JUnit5. Apparently, specifying the platform causes the maven-surefire-plugin to fail in finding any JUnit 5 tests. Regardless of specifying testng otherwise correctly. I have not found a clear-cut solution to support both test frameworks through surefire and, frankly give up. Running the ResultStreamPublisherTest (the only testng test) separately still works, so we do not lose validation entirely. #416
1 parent fc224d5 commit f3be72d

File tree

1 file changed

+16
-40
lines changed

1 file changed

+16
-40
lines changed

pom.xml

Lines changed: 16 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
<junit.jupiter.version>5.12.1</junit.jupiter.version>
6262
<mockito.version>5.14.2</mockito.version>
6363
<testcontainers.version>1.20.6</testcontainers.version>
64-
<testng.version>7.10.2</testng.version>
64+
<testng.version>7.11.0</testng.version>
6565

6666
<httpclient5.version>5.4.2</httpclient5.version>
6767
<toxiproxy.version>2.1.7</toxiproxy.version>
@@ -90,11 +90,6 @@
9090
<type>pom</type>
9191
<scope>import</scope>
9292
</dependency>
93-
<dependency>
94-
<groupId>org.mockito</groupId>
95-
<artifactId>mockito-core</artifactId>
96-
<version>${mockito.version}</version>
97-
</dependency>
9893
<dependency>
9994
<groupId>org.slf4j</groupId>
10095
<artifactId>slf4j-api</artifactId>
@@ -106,24 +101,22 @@
106101
<version>${slf4j.version}</version>
107102
</dependency>
108103
<dependency>
109-
<groupId>org.junit.jupiter</groupId>
110-
<artifactId>junit-jupiter-api</artifactId>
111-
<version>${junit.jupiter.version}</version>
112-
</dependency>
113-
<dependency>
114-
<groupId>org.junit.jupiter</groupId>
115-
<artifactId>junit-jupiter-params</artifactId>
116-
<version>${junit.jupiter.version}</version>
104+
<groupId>org.reactivestreams</groupId>
105+
<artifactId>reactive-streams</artifactId>
106+
<version>${reactive.streams.version}</version>
117107
</dependency>
108+
<!-- Testing -->
118109
<dependency>
119-
<groupId>org.junit.jupiter</groupId>
120-
<artifactId>junit-jupiter-engine</artifactId>
110+
<groupId>org.junit</groupId>
111+
<artifactId>junit-bom</artifactId>
121112
<version>${junit.jupiter.version}</version>
113+
<type>pom</type>
114+
<scope>import</scope>
122115
</dependency>
123116
<dependency>
124-
<groupId>org.reactivestreams</groupId>
125-
<artifactId>reactive-streams</artifactId>
126-
<version>${reactive.streams.version}</version>
117+
<groupId>org.mockito</groupId>
118+
<artifactId>mockito-core</artifactId>
119+
<version>${mockito.version}</version>
127120
</dependency>
128121
<dependency>
129122
<groupId>io.projectreactor</groupId>
@@ -145,9 +138,9 @@
145138
<scope>test</scope>
146139
</dependency>
147140
<dependency>
148-
<groupId>com.github.testng-team</groupId>
149-
<artifactId>testng-junit5</artifactId>
150-
<version>1.0.4</version>
141+
<groupId>org.junit.support</groupId>
142+
<artifactId>testng-engine</artifactId>
143+
<version>1.0.5</version>
151144
<scope>test</scope>
152145
</dependency>
153146
</dependencies>
@@ -248,17 +241,7 @@
248241
<!-- Testing -->
249242
<dependency>
250243
<groupId>org.junit.jupiter</groupId>
251-
<artifactId>junit-jupiter-api</artifactId>
252-
<scope>test</scope>
253-
</dependency>
254-
<dependency>
255-
<groupId>org.junit.jupiter</groupId>
256-
<artifactId>junit-jupiter-params</artifactId>
257-
<scope>test</scope>
258-
</dependency>
259-
<dependency>
260-
<groupId>org.junit.jupiter</groupId>
261-
<artifactId>junit-jupiter-engine</artifactId>
244+
<artifactId>junit-jupiter</artifactId>
262245
<scope>test</scope>
263246
</dependency>
264247
<dependency>
@@ -433,13 +416,6 @@
433416
<include>**/*Tests_*.java</include>
434417
</includes>
435418
</configuration>
436-
<dependencies>
437-
<dependency>
438-
<groupId>org.apache.maven.surefire</groupId>
439-
<artifactId>surefire-junit-platform</artifactId>
440-
<version>${maven.surefire.plugin.version}</version>
441-
</dependency>
442-
</dependencies>
443419
</plugin>
444420
<plugin>
445421
<artifactId>maven-javadoc-plugin</artifactId>

0 commit comments

Comments
 (0)