Skip to content

Commit a6d0808

Browse files
committed
We should have beforeMergeCallback for feature too
This is consistent with the other finish methods. It is necessary to inform the caller of what operations nodegit-flow intends to make on the repository.
1 parent 32ebb23 commit a6d0808

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/Feature.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ class Feature {
7474
keepBranch,
7575
isRebase,
7676
preRebaseCallback = () => {},
77+
beforeMergeCallback = () => {},
7778
processMergeMessageCallback,
7879
postMergeCallback = () => {},
7980
beforeRebaseFinishCallback = () => {}
@@ -121,7 +122,8 @@ class Feature {
121122
cancelDevelopMerge = isSameCommit || isRebase;
122123

123124
if (!cancelDevelopMerge) {
124-
return utils.Repo.merge(developBranch, featureBranch, repo, processMergeMessageCallback)
125+
return Promise.resolve(beforeMergeCallback(developBranch, featureBranch))
126+
.then(() => utils.Repo.merge(developBranch, featureBranch, repo, processMergeMessageCallback))
125127
.then(utils.InjectIntermediateCallback(postMergeCallback));
126128
} else if (isRebase && !isSameCommit) {
127129
return Promise.resolve(preRebaseCallback(developBranchName, featureBranchName))

0 commit comments

Comments
 (0)