Use semver for dependency version comparisons

Author: Joshua Grosso

package.json

@@ -60,6 +60,7 @@
     "node-pty": "github:implausible/node-pty#57f5f4ef6b751ffcd056fb6f2b626a0a0d804301",
     "promisify-node": "^0.4.0",
     "ramda": "^0.24.1",
+    "semver": "^5.4.1",
     "tmp": "^0.0.33"
   }
 }

src/utils/checkDependencies.js

@@ -1,17 +1,15 @@
 import fse from 'fs-extra';
 import path from 'path';
 import R from 'ramda';
-
-import {
-  gitVersion,
-  lfsVersion
-} from '../commands/version';
-import generateResponse from './generateResponse';
+import semver from 'semver';
 
 import {
   minimumVersions,
   BAD_VERSION
 } from '../constants';
+import generateResponse from './generateResponse';
+
+import { gitVersion, lfsVersion } from '../commands/version';
 
 /**
  * @function normalizeVersion
@@ -62,7 +60,7 @@ const handleVersionResponse = (dependencyName, response) => {
   }
 
   const exists = version !== BAD_VERSION;
-  const meetsVersion = exists && version >= minimumVersions[dependencyName];
+  const meetsVersion = exists && semver.gte(version, minimumVersions[dependencyName]);
 
   const constructKey = key => `${R.toLower(dependencyName)}_${key}`;
   return {

yarn.lock

@@ -2343,11 +2343,7 @@ mute-stream@~0.0.4:
   version "0.0.7"
   resolved "https://registry.yarnpkg.com/mute-stream/-/mute-stream-0.0.7.tgz#3075ce93bc21b8fab43e1bc4da7e8115ed1e7bab"
 
-nan@^2.3.0:
-  version "2.5.0"
-  resolved "https://registry.yarnpkg.com/nan/-/nan-2.5.0.tgz#aa8f1e34531d807e9e27755b234b4a6ec0c152a8"
-
-nan@^2.6.2:
+nan@^2.3.0, nan@^2.6.2:
   version "2.7.0"
   resolved "https://registry.yarnpkg.com/nan/-/nan-2.7.0.tgz#d95bf721ec877e08db276ed3fc6eb78f9083ad46"
 
@@ -3011,7 +3007,7 @@ [email protected], samsam@^1.1.3:
   version "1.2.1"
   resolved "https://registry.yarnpkg.com/samsam/-/samsam-1.2.1.tgz#edd39093a3184370cb859243b2bdf255e7d8ea67"
 
-"semver@2 || 3 || 4 || 5", semver@^5.3.0:
+"semver@2 || 3 || 4 || 5", semver@^5.3.0, semver@^5.4.1:
   version "5.4.1"
   resolved "https://registry.yarnpkg.com/semver/-/semver-5.4.1.tgz#e059c09d8571f0540823733433505d3a2f00b18e"