Standardize error-handling logic

Author: Joshua Grosso

src/commands/checkout.js

@@ -55,10 +55,9 @@ const generateCheckoutStats = (raw) => {
 };
 
 function checkout(repo) {
-  const response = generateResponse();
-
   return core.checkout('', { cwd: repo.workdir() })
     .then(({ stdout, stderr }) => {
+      const response = generateResponse();
       response.raw = stdout;
 
       if (stderr) {

src/commands/clone.js

@@ -70,13 +70,12 @@ function clone(url, cwd, options) {
   } = (options || {});
   const args = branch ? `-b ${branch}` : '';
 
-  const response = generateResponse();
   return core.clone(`${url} ${args}`, { cwd, env }, callback)
-    .then(({ stdout }) => {
-      response.raw = stdout;
-      response.clone = generateCloneStats(stdout);
-      return response;
-    }, errorCatchHandler(response));
+    .then(({ stdout }) => ({
+      ...generateResponse(),
+      raw: stdout,
+      clone: generateCloneStats(stdout)
+    }), errorCatchHandler);
 }
 
 export default clone;

src/commands/fetch.js

@@ -60,8 +60,6 @@ const generateFetchStats = (raw) => {
 };
 
 function fetch(repo, options) {
-  const response = generateResponse();
-
   const args = [];
   const {
     remoteName,
@@ -84,9 +82,9 @@ function fetch(repo, options) {
       response.fetch = generateFetchStats(stdout);
 
       if (response.fetch.fetch_error) {
-        response.success = false;
-        response.stderr = response.fetch.fetch_error;
         response.errno = BAD_CORE_RESPONSE;
+        response.stderr = response.fetch.fetch_error;
+        response.success = false;
       }
 
       return response;

src/commands/ls.js

@@ -47,17 +47,18 @@ const buildArgs = (options) => {
 };
 
 const ls = (repo, options) => {
-  const response = generateResponse();
   const args = buildArgs(options);
 
   return core.ls(args, { cwd: repo.workdir() })
     .then(({ stdout, stderr }) => {
+      const response = generateResponse();
       response.raw = stdout;
 
-      if (stderr.length > 0) {
+      if (stderr) {
+        response.errno = BAD_CORE_RESPONSE;
         response.stderr = stderr;
         response.success = false;
-        response.errno = BAD_CORE_RESPONSE;
+        return response;
       }
 
       response.files = extractFileNames(stdout);

src/commands/pointer.js

@@ -13,16 +13,16 @@ const pointer = (repo, filePath, pointerPath) => {
     args += `--file=${pointerPath} `;
   }
 
-  const response = generateResponse();
 
   return core.pointer(args, { cwd: repo.workdir() })
     .then(({ stdout, stderr }) => {
+      const response = generateResponse();
       response.raw = stdout;
 
       if (stderr) {
-        response.success = false;
         response.errno = BAD_CORE_RESPONSE;
         response.stderr = stderr;
+        response.success = false;
         return response;
       }
 

src/commands/prune.js

@@ -2,22 +2,19 @@ import { core } from './lfsCommands';
 import generateResponse from '../utils/generateResponse';
 import { BAD_CORE_RESPONSE } from '../constants';
 
-const prune = (repo, args) => {
-  const response = generateResponse();
-
-  return core.prune(args, { cwd: repo.workdir() })
+const prune = (repo, args) =>
+  core.prune(args, { cwd: repo.workdir() })
     .then(({ stdout, stderr }) => {
+      const response = generateResponse();
       response.raw = stdout;
 
       if (stderr) {
         response.errno = BAD_CORE_RESPONSE;
         response.stderr = stderr;
         response.success = false;
-        return response;
       }
 
       return response;
     });
-};
 
 export default prune;

src/commands/pull.js

@@ -60,8 +60,6 @@ const generatePullStats = (raw) => {
 };
 
 function pull(repo, options) {
-  const response = generateResponse();
-
   const args = [];
   const {
     remoteName,
@@ -83,9 +81,9 @@ function pull(repo, options) {
       response.pull = generatePullStats(stdout);
 
       if (response.pull.pull_error) {
-        response.success = false;
-        response.stderr = response.pull.pull_error;
         response.errno = BAD_CORE_RESPONSE;
+        response.stderr = response.pull.pull_error;
+        response.success = false;
       }
 
       return response;

src/commands/push.js

@@ -62,8 +62,6 @@ const generatePushStats = (raw) => {
 };
 
 function push(repo, options) {
-  const response = generateResponse();
-
   const {
     remoteName,
     branchName,
@@ -96,11 +94,11 @@ function push(repo, options) {
 
   return getRemoteAndBranchPromise
     .then(() => core.push(`${remote} ${branch}`, { cwd: repo.path() }, callback))
-    .then(({ stdout }) => {
-      response.raw = stdout;
-      response.push = generatePushStats(stdout);
-      return response;
-    }, errorCatchHandler(response));
+    .then(({ stdout }) => ({
+      ...generateResponse(),
+      push: generatePushStats(stdout),
+      raw: stdout
+    }), errorCatchHandler);
 }
 
 export default push;

src/commands/track.js

@@ -22,16 +22,16 @@ const track = (repo, globs) => {
     R.filter(isString),
     R.map(g => `${ticks}${g}${ticks}`)
   )(globs);
-  const response = generateResponse();
 
   return core.track(R.join(' ', filteredGlobs), { cwd: repo.workdir() })
     .then(({ stdout, stderr }) => {
+      const response = generateResponse();
       response.raw = stdout;
 
       if (stderr) {
-        response.success = false;
         response.errno = BAD_CORE_RESPONSE;
         response.stderr = stderr;
+        response.success = false;
         return response;
       }
 

src/commands/untrack.js

@@ -22,16 +22,16 @@ const untrack = (repo, globs) => {
     R.filter(isString),
     R.map(g => `${ticks}${g}${ticks}`)
   )(globs);
-  const response = generateResponse();
 
   return core.untrack(R.join(' ', filteredGlobs), { cwd: repo.workdir() })
     .then(({ stdout, stderr }) => {
+      const response = generateResponse();
       response.raw = stdout;
 
       if (stderr) {
-        response.success = false;
         response.errno = BAD_CORE_RESPONSE;
         response.stderr = stderr;
+        response.success = false;
         return response;
       }