Skip to content

Commit 089c0c5

Browse files
CopilotAyRickk
andcommitted
Fix file naming convention and property visibility
- Rename ThinkingTagExtractor.ts to thinkingTagExtractor.ts (follow lowercase convention in llm/) - Rename ThinkingTagExtractor.vitest.ts to thinkingTagExtractor.vitest.ts - Update imports in Vllm.ts and test file - Change thinkingOpenTag/thinkingCloseTag from protected to private Co-authored-by: AyRickk <[email protected]>
1 parent 80b056d commit 089c0c5

File tree

4 files changed

+4
-221
lines changed

4 files changed

+4
-221
lines changed

core/llm/ThinkingTagExtractor.vitest.ts

Lines changed: 0 additions & 217 deletions
This file was deleted.

core/llm/llms/Vllm.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { ChatMessage, Chunk, CompletionOptions, LLMOptions } from "../../index.js";
22

33
import { LlmApiRequestType } from "../openaiTypeConverters.js";
4-
import { ThinkingTagExtractor } from "../ThinkingTagExtractor.js";
4+
import { ThinkingTagExtractor } from "../thinkingTagExtractor.js";
55
import OpenAI from "./OpenAI.js";
66

77
// vLLM-specific rerank response types
@@ -66,8 +66,8 @@ class Vllm extends OpenAI {
6666
static providerName = "vllm";
6767

6868
// vLLM-specific options for thinking tag extraction
69-
protected thinkingOpenTag?: string;
70-
protected thinkingCloseTag?: string;
69+
private thinkingOpenTag?: string;
70+
private thinkingCloseTag?: string;
7171

7272
// Override useOpenAIAdapterFor to NOT include "streamChat".
7373
// vLLM uses the reasoning_content field for thinking output (via vLLM's reasoning parser),
File renamed without changes.

core/llm/thinkingTagExtractor.vitest.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { describe, expect, it } from "vitest";
2-
import { ThinkingTagExtractor } from "./ThinkingTagExtractor";
2+
import { ThinkingTagExtractor } from "./thinkingTagExtractor";
33

44
describe("ThinkingTagExtractor", () => {
55
describe("basic functionality", () => {

0 commit comments

Comments
 (0)