feat: allow commit releases (#18278)

Please read [contributing guidelines](CONTRIBUTING.md) and remove this
line.

For audit-related pull requests, please use the [audit PR
template](?expand=1&template=audit.md).

Author: AztecBot

.github/workflows/ci3.yml

@@ -78,6 +78,10 @@ jobs:
         if: contains(github.event.pull_request.labels.*.name, 'barretenberg-ci') || (github.event.pull_request.base.ref == 'merge-train/barretenberg')
         run: echo "CI_BARRETENBERG=1" >> $GITHUB_ENV
 
+      - name: CI Release PR Override
+        if: contains(github.event.pull_request.labels.*.name, 'ci-release-pr')
+        run: echo "CI_RELEASE_PR=1" >> $GITHUB_ENV
+
       # Allow full concurrency for merge-train PRs, one-run-per-branch for everything else.
       - name: Set Instance Postfix for merge-train
         if: startsWith(github.event.pull_request.head.ref, 'merge-train/')
@@ -139,17 +143,21 @@ jobs:
           EXTERNAL_ETHEREUM_CONSENSUS_HOST_API_KEY: ${{ secrets.GCP_SEPOLIA_API_KEY }}
           EXTERNAL_ETHEREUM_CONSENSUS_HOST_API_KEY_HEADER: "X-goog-api-key"
           GCP_PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }}
+          PR_NUMBER: ${{ github.event.pull_request.number }}
         run: |
           if [ "${{ github.event_name }}" == "merge_group" ] || [ "${CI_MERGE_QUEUE:-0}" -eq 1 ]; then
             exec ./ci.sh merge-queue
+          elif [ "${CI_RELEASE_PR:-0}" -eq 1 ]; then
+            git remote set-url origin https://x-access-token:${GITHUB_TOKEN}@github.com/${{ github.repository }}
+            tag_name="v0.0.1-commit.$(git rev-parse --short HEAD)"
+            git tag ${tag_name}
+            git push origin ${tag_name}
           elif [ "${CI_FULL:-0}" -eq 1 ]; then
             exec ./ci.sh full
           elif [ "${CI_DOCS:-0}" -eq 1 ]; then
             exec ./ci.sh docs
           elif [ "${CI_BARRETENBERG:-0}" -eq 1 ]; then
             exec ./ci.sh barretenberg
-          elif [ "${{ contains(github.ref, '-nightly.') }}" == "true" ] || [ "${{ contains(github.ref, '-rc.') }}" == "true" ]; then
-            exec ./ci.sh nightly
           elif [ "${{ startsWith(github.ref, 'refs/tags/v') }}" == "true" ]; then
             exec ./ci.sh release
           else

.github/workflows/test-network-scenarios.yml

@@ -51,7 +51,7 @@ jobs:
         run: |
           git fetch --tags --force
           tag=$(git tag --points-at "${{ github.event.workflow_run.head_sha }}" | head -n1)
-          if echo "$tag" | grep -Eq '^v[0-9]+\.[0-9]+\.[0-9]+' && ! echo "$tag" | grep -q 'fake'; then
+          if echo "$tag" | grep -Eq '^v[0-9]+\.[0-9]+\.[0-9]+' && ! echo "$tag" | grep -q 'commit'; then
             echo "should_run=true" >> $GITHUB_OUTPUT
             echo "Found semver tag: $tag"
           else

.test_patterns.yml

@@ -99,6 +99,10 @@ tests:
     skip: true
     owners:
       - *charlie
+  - regex: "noir-protocol-circuits blob blob_batching::tests::test_max_blobs_batched"
+    error_regex: "core dumped"
+    owners:
+      - *tom
 
   # AD: hit this flake
   # 18:04:38 thread 'arb_program_freqs_in_expected_range' panicked at tooling/ast_fuzzer/tests/calibration.rs:75:5:

bootstrap.sh

@@ -176,11 +176,7 @@ function test_cmds {
 
 function start_test_env {
   # Starting txe servers with incrementing port numbers.
-  trap '(kill -SIGTERM $txe_pids &>/dev/null || true) && ./spartan/bootstrap.sh stop_env' EXIT
-
-  # Start env for spartan tests in the background
-  dump_fail "spartan/bootstrap.sh start_env" &
-  spartan_pid=$!
+  trap 'kill -SIGTERM $txe_pids &>/dev/null || true' EXIT
 
   for i in $(seq 0 $((NUM_TXES-1))); do
     port=$((45730 + i))
@@ -203,13 +199,6 @@ function start_test_env {
         j=$((j+1))
       done
   done
-
-  echo "Waiting for spartan environment to complete setup..."
-  if wait $spartan_pid; then
-    echo "Spartan environment setup completed successfully."
-  else
-    echo_stderr "Spartan environment setup failed. Exiting."
-  fi
 }
 
 function test {
@@ -444,16 +433,6 @@ case "$cmd" in
     test
     bench
     ;;
-  "ci-nightly")
-    export CI=1
-    export USE_TEST_CACHE=1
-    export CI_NIGHTLY=1
-    build
-    release-image/bootstrap.sh push
-    # TODO this should become a ci-nightly-tests ran in parallel with a normal ci-release
-    # test
-    release
-    ;;
   "ci-network-deploy")
     export CI=1
     build

ci.sh

@@ -105,6 +105,7 @@ function run_ci_with_cache {
   # Upload success marker
   echo "success" > success.txt
   cache_upload "$cache_key" success.txt
+  rm success.txt
 }
 
 case "$cmd" in
@@ -152,18 +153,6 @@ case "$cmd" in
     export AWS_SHUTDOWN_TIME=360 # 6 hours for network tests
     bootstrap_ec2 "./bootstrap.sh ci-network-tests"
     ;;
-  "nightly")
-    prep_vars
-    # Spin up ec2 instance and run the nightly flow.
-    run() {
-      JOB_ID=$1 INSTANCE_POSTFIX=$1 ARCH=$2 exec denoise "bootstrap_ec2 './bootstrap.sh ci-nightly'"
-    }
-    export -f run
-    # We need to run the release flow on both x86 and arm64.
-    parallel --termseq 'TERM,10000' --tagstring '{= $_=~s/run (\w+).*/$1/; =}' --line-buffered --halt now,fail=1 ::: \
-      'run x-nightly amd64' \
-      'run a-nightly arm64' | DUP=1 cache_log "Nightly CI run" $RUN_ID
-    ;;
   "release")
     prep_vars
     # Spin up ec2 instance and run the release flow.
@@ -175,6 +164,10 @@ case "$cmd" in
     parallel --termseq 'TERM,10000' --tagstring '{= $_=~s/run (\w+).*/$1/; =}' --line-buffered --halt now,fail=1 ::: \
       'run x-release amd64' \
       'run a-release arm64' | DUP=1 cache_log "Release CI run" $RUN_ID
+    # If we were triggered by a PR with ci-release-pr label, remove the label now we've succeeded.
+    if [ -n "${PR_NUMBER:-}" ]; then
+      gh pr edit $PR_NUMBER --remove-label ci-release-pr || true
+    fi
     ;;
   "shell-new")
     # Spin up ec2 instance, clone, and drop into shell.

ci3/source_refname

@@ -36,7 +36,6 @@ if [ -z "${CI_FULL:-}" ]; then
     export CI_FULL=1
   fi
 fi
-export CI_NIGHTLY="${CI_NIGHTLY:-0}"
 export CI_SCENARIO_TEST="${CI_SCENARIO_TEST:-0}"
 
 if [ -z "${COMMIT_HASH:-}" ]; then

spartan/bootstrap.sh

@@ -87,19 +87,6 @@ function single_test {
   $root/yarn-project/end-to-end/scripts/run_test.sh simple $test_file
 }
 
-function start_env {
-  if [ "$CI_NIGHTLY" -eq 1 ] && [ "$(arch)" != "arm64" ]; then
-    echo "Skipping start_env for nightly while we migrate to use the same deployment flow as the scenario/staging networks."
-  fi
-}
-
-function stop_env {
-  if [ "$CI_NIGHTLY" -eq 1 ] && [ "$(arch)" != "arm64" ]; then
-    echo "Skipping stop_env for nightly while we migrate to use the same deployment flow as the scenario/staging networks."
-  fi
-}
-
-
 function test {
   echo_header "spartan test (deprecated)"
   # the existing test flow is deprecated.
@@ -230,7 +217,7 @@ case "$cmd" in
   "hash")
     echo $hash
     ;;
-  test|test_cmds|gke|build|start_env|stop_env|gcp_auth)
+  test|test_cmds|gke|build|gcp_auth)
     $cmd
     ;;
   "test-kind-smoke")