fix: throw when making Fr from negatives

IlyasRidhuan · alexghr · commit 0523ec8e0930 · 2025-08-25T15:51:21.000+01:00
diff --git a/yarn-project/foundation/src/fields/fields.ts b/yarn-project/foundation/src/fields/fields.ts
@@ -60,6 +60,8 @@ abstract class BaseField {
       this.asBigInt = BigInt(value);
       if (this.asBigInt >= this.modulus()) {
         throw new Error(`Value 0x${this.asBigInt.toString(16)} is greater or equal to field modulus.`);
+      } else if (this.asBigInt < 0n) {
+        throw new Error(`Value 0x${this.asBigInt.toString(16)} is negative.`);
       }
     } else if (value instanceof BaseField) {
       this.asBuffer = value.asBuffer;

Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,8 @@ abstract class BaseField {`
`60`	`60`	`this.asBigInt = BigInt(value);`
`61`	`61`	`if (this.asBigInt >= this.modulus()) {`
`62`	`62`	throw new Error(`Value 0x${this.asBigInt.toString(16)} is greater or equal to field modulus.`);
	`63`	`+ } else if (this.asBigInt < 0n) {`
	`64`	+ throw new Error(`Value 0x${this.asBigInt.toString(16)} is negative.`);
`63`	`65`	`}`
`64`	`66`	`} else if (value instanceof BaseField) {`
`65`	`67`	`this.asBuffer = value.asBuffer;`