Skip to content

Commit 058a007

Browse files
authored
fix(ci): restore SSH access for external CI workflows (#19005)
Fixes SSH access for external contributors that was broken in #17978. ## Problem External CI workflows cannot SSH into EC2 instances because SSH key setup became conditional on `CI_INTERNAL=1`, which external workflows don't set. ## Solution Remove the `CI_INTERNAL` check from SSH key setup in `.github/ci3.sh`. The SSH key is needed by the GitHub Actions runner to connect to EC2 instances. Security is maintained because the SSH key is still only copied INTO instances when `CI_ENABLE_DISK_LOGS=1` (internal CI only, see `ci3/bootstrap_ec2:210-220`).
2 parents 00c514f + b7f5737 commit 058a007

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/ci3.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,9 @@ function setup_environment {
3636
echo "INSTANCE_POSTFIX=$INSTANCE_POSTFIX" >> $GITHUB_ENV
3737
echo "Instance postfix set to: $INSTANCE_POSTFIX"
3838
fi
39-
# Setup SSH key (internal only)
40-
if [ "${CI_INTERNAL:-0}" -eq 1 ] && [ -n "${BUILD_INSTANCE_SSH_KEY:-}" ]; then
39+
# Setup SSH key for connecting to EC2 instances
40+
# Note: The key is used to SSH into instances but is only copied INTO instances when CI_ENABLE_DISK_LOGS=1 (internal CI only)
41+
if [ -n "${BUILD_INSTANCE_SSH_KEY:-}" ]; then
4142
mkdir -p ~/.ssh
4243
echo "${BUILD_INSTANCE_SSH_KEY}" | base64 --decode > ~/.ssh/build_instance_key
4344
chmod 600 ~/.ssh/build_instance_key

0 commit comments

Comments
 (0)